Bug 236742

Summary: [WebGPU] Add a playground example target
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, rmorisset, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch dino: review+, ews-feeder: commit-queue-

Myles C. Maxfield
Reported 2022-02-16 17:11:23 PST
[WebGPU] Add a playground example target
Attachments
Patch (15.69 KB, patch)
2022-02-16 17:13 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (16.93 KB, patch)
2022-02-16 17:15 PST, Myles C. Maxfield 		dino: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2022-02-16 17:13:40 PST
Created attachment 452274 [details] Patch
Myles C. Maxfield
Comment 2 2022-02-16 17:15:45 PST
Created attachment 452275 [details] Patch
Dean Jackson
Comment 3 2022-02-17 04:46:55 PST
Comment on attachment 452275 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452275&action=review > Source/WebGPU/CommandLinePlayground/main.swift:29 > +autoreleasepool { why does this have to be in an autoreleasepool? > Source/WebGPU/CommandLinePlayground/main.swift:36 > + var _ = WGPUTextureDescriptorViewFormats(chain: WGPUChainedStruct(next: nil, sType: WGPUSType(rawValue: WGPUSTypeExtended_TextureDescriptorViewFormats.rawValue)), viewFormatsCount: 0, viewFormats: nil) let?
Myles C. Maxfield
Comment 4 2022-02-17 13:26:54 PST
Comment on attachment 452275 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452275&action=review >> Source/WebGPU/CommandLinePlayground/main.swift:29 >> +autoreleasepool { > > why does this have to be in an autoreleasepool? It doesn't. I'll delete it. >> Source/WebGPU/CommandLinePlayground/main.swift:36 >> + var _ = WGPUTextureDescriptorViewFormats(chain: WGPUChainedStruct(next: nil, sType: WGPUSType(rawValue: WGPUSTypeExtended_TextureDescriptorViewFormats.rawValue)), viewFormatsCount: 0, viewFormats: nil) > > let? Yep! Good catch. > Source/WebGPU/Configurations/CommandLinePlayground.xcconfig:24 > +PRODUCT_NAME = CommandLinePlayground; SWIFT_VERSION = 5.0;
Myles C. Maxfield
Comment 5 2022-02-17 13:32:25 PST
Committed r290069 (?): <https://commits.webkit.org/r290069>
Radar WebKit Bug Importer
Comment 6 2022-02-17 13:33:19 PST
<rdar://problem/89105914>
Note You need to log in before you can comment on or make changes to this bug.