Bug 236733

Summary: Metal ANGLE: vertex array does not correctly observe contents of data buffers
Product: WebKit Reporter: Kyle Piddington <kpiddington>
Component: New BugsAssignee: Kyle Piddington <kpiddington>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, kbr, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=236713
Bug Depends on: 220896    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch dino: review+

Description Kyle Piddington 2022-02-16 14:30:39 PST 
Metal ANGLE: vertex array does not correctly observe contents of data buffers
Comment 1 Kyle Piddington 2022-02-16 14:33:11 PST 
Created attachment 452250 [details]
Patch
Comment 2 Kyle Piddington 2022-02-16 14:33:14 PST 
<rdar://problem/88713302>
Comment 3 EWS Watchlist 2022-02-16 14:34:41 PST 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 4 Dean Jackson 2022-02-16 14:40:58 PST 
Comment on attachment 452250 [details]
Patch

Is there some way we could have a test for this?
Comment 5 Kyle Piddington 2022-02-16 15:28:13 PST 
Created attachment 452258 [details]
Patch
Comment 6 Kyle Piddington 2022-02-16 16:10:48 PST 
Created attachment 452267 [details]
Patch
Comment 7 Kyle Piddington 2022-02-16 16:11:39 PST 
Comment on attachment 452258 [details]
Patch

Obsoleted, added test.
Comment 8 Kyle Piddington 2022-02-16 16:11:57 PST 
D(In reply to Dean Jackson from comment #4)
> Comment on attachment 452250 [details]
> Patch
> 
> Is there some way we could have a test for this?

Done!
Comment 9 Dean Jackson 2022-02-17 08:05:52 PST 
Comment on attachment 452267 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452267&action=review

I think the tests themselves are missing?

> LayoutTests/fast/canvas/buffer-data-subdata-dynamic-expected.txt:11
> +CONSOLE MESSAGE: ReferenceError: Can't find variable: debug
> +layer at (0,0) size 800x600
> +  RenderView at (0,0) size 800x600
> +layer at (0,0) size 800x60
> +  RenderBlock {HTML} at (0,0) size 800x60
> +    RenderBody {BODY} at (8,8) size 784x44
> +      RenderBlock (anonymous) at (0,0) size 784x44
> +        RenderHTMLCanvas {CANVAS} at (0,0) size 40x40
> +        RenderText {#text} at (0,0) size 0x0
> +      RenderBlock {DIV} at (0,44) size 784x0
> +      RenderBlock {DIV} at (0,44) size 784x0

Oops. Looks like the test here has a typo and isn't dumping as text.
Comment 10 Kyle Piddington 2022-02-17 13:08:12 PST 
Created attachment 452421 [details]
Patch
Comment 11 Kyle Piddington 2022-02-17 14:04:48 PST 
Created attachment 452431 [details]
Patch
Comment 12 Dean Jackson 2022-02-17 16:10:38 PST 
Committed r290087 (247442@trunk): <https://commits.webkit.org/247442@trunk>