| Summary: | [LFC][Integration] LineLayout::firstLineBaseline callers expect physical position | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
zalan
2022-02-15 21:08:10 PST
Created attachment 452141 [details]
Patch
Comment on attachment 452141 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452141&action=review > Source/WebCore/rendering/RenderBlockFlow.cpp:2962 > + return LayoutUnit { floorToInt(modernLineLayout()->firstLinePhysicalBaseline()) }; would be nice to rename RenderBlockFlow::firstLineBaseline etc too (In reply to Antti Koivisto from comment #2) > Comment on attachment 452141 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=452141&action=review > > > Source/WebCore/rendering/RenderBlockFlow.cpp:2962 > > + return LayoutUnit { floorToInt(modernLineLayout()->firstLinePhysicalBaseline()) }; > > would be nice to rename RenderBlockFlow::firstLineBaseline etc too Good idea. will do it in a follow up patch! Committed r289897 (247333@main): <https://commits.webkit.org/247333@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452141 [details]. |