Bug 236605

Summary: [CMake] Remove uses of add_definitions in JavaScriptCore build
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: CMakeAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, mcatanzaro, msaboff, ryuan.choi, saam, sergio, tzagallo
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Don Olmstead
Reported 2022-02-14 12:59:53 PST
Use modern CMake way of setting definitions.
Attachments
Patch (2.63 KB, patch)
2022-02-14 13:19 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2022-02-14 13:19:16 PST
Created attachment 451936 [details] Patch
EWS
Comment 2 2022-02-14 16:10:23 PST
Committed r289779 (247247@main): <https://commits.webkit.org/247247@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451936 [details].
Note You need to log in before you can comment on or make changes to this bug.