Bug 236602

Summary: [macOS] Add a context menu item to "Copy Cropped Image"
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: PlatformAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, cdumez, ews-watchlist, hi, japhet, katherine_cheney, megan_gardner, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 236628    
Attachments:
Description Flags
Patch
megan_gardner: review+
Patch for landing none

Wenson Hsieh
Reported 2022-02-14 12:01:25 PST
.
Attachments
Patch (25.83 KB, patch)
2022-02-14 12:20 PST, Wenson Hsieh 		megan_gardner: review+
DetailsFormatted DiffDiff
Patch for landing (25.90 KB, patch)
2022-02-15 11:43 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2022-02-14 12:20:22 PST
Created attachment 451931 [details] Patch
Radar WebKit Bug Importer
Comment 2 2022-02-14 13:13:30 PST
<rdar://problem/88924479>
Megan Gardner
Comment 3 2022-02-15 11:15:47 PST
Comment on attachment 451931 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451931&action=review > Source/WebCore/page/ContextMenuController.cpp:258 > + break; Why are we sure we won't ever get here?
Wenson Hsieh
Comment 4 2022-02-15 11:20:21 PST
Comment on attachment 451931 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451931&action=review Thanks for the review! >> Source/WebCore/page/ContextMenuController.cpp:258 >> + break; > > Why are we sure we won't ever get here? Good question! We won't ever get here because we expect to handle this item in the client layer, similar to ContextMenuItemTagQuickLookImage. I'll move this case down next to ContextMenuItemTagQuickLookImage, so that the "This should be handled at the client layer." comment will apply to both.
Wenson Hsieh
Comment 5 2022-02-15 11:43:48 PST
Created attachment 452070 [details] Patch for landing
EWS
Comment 6 2022-02-15 13:58:22 PST
Committed r289851 (247293@main): <https://commits.webkit.org/247293@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452070 [details].
Note You need to log in before you can comment on or make changes to this bug.