Bug 236571

Summary: Consistenly use hasTagName instead of is<> in HTMLStackItem testing functions
Product: WebKit Reporter: Cameron McCormack (:heycam) <heycam>
Component: DOMAssignee: Cameron McCormack (:heycam) <heycam>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, esprehn+autocc, ews-watchlist, gyuyoung.kim, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Cameron McCormack (:heycam)
Reported 2022-02-13 14:16:06 PST
No reason to use is<> for a couple of element names but hasTagName for all others.
Attachments
Patch (2.20 KB, patch)
2022-02-13 14:19 PST, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Cameron McCormack (:heycam)
Comment 1 2022-02-13 14:19:04 PST
Created attachment 451843 [details] Patch
Sam Weinig
Comment 2 2022-02-14 13:26:42 PST
Comment on attachment 451843 [details] Patch Looks like this was done intentionally way back in http://trac.webkit.org/changeset/152440/webkit, but also seems like it was not the right choice.
EWS
Comment 3 2022-02-14 16:01:17 PST
Committed r289777 (247245@main): <https://commits.webkit.org/247245@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451843 [details].
Radar WebKit Bug Importer
Comment 4 2022-02-14 16:02:17 PST
<rdar://problem/88933767>
Note You need to log in before you can comment on or make changes to this bug.