Bug 23657

Summary: Clean up Storage IDLs
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: WebCore Misc.Assignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Trivial    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
v1 submitted for review
sam: review+
Remove IDLs from the project fishd: review+

Description Dimitri Glazkov (Google) 2009-01-30 15:00:11 PST 
All callbacks are custom-baked, so there's no need for their IDLs to float around. Also, I flipped int attributes to be long in SQLError and SQLResultSet, as spec suggested. This is purely cosmetic, but makes our IDLs match the spec better.
Comment 1 Dimitri Glazkov (Google) 2009-01-30 15:03:30 PST 
Created attachment 27198 [details]
v1 submitted for review

 WebCore/ChangeLog                               |   14 +++++++++
 WebCore/storage/SQLError.idl                    |    2 +-
 WebCore/storage/SQLResultSet.idl                |    4 +-
 WebCore/storage/SQLStatementCallback.idl        |   35 -----------------------
 WebCore/storage/SQLStatementErrorCallback.idl   |   35 -----------------------
 WebCore/storage/SQLTransactionCallback.idl      |   35 -----------------------
 WebCore/storage/SQLTransactionErrorCallback.idl |   35 -----------------------
 7 files changed, 17 insertions(+), 143 deletions(-)
Comment 2 Dimitri Glazkov (Google) 2009-02-04 15:36:47 PST 
Landed as http://trac.webkit.org/changeset/40633.
Comment 3 Dimitri Glazkov (Google) 2009-03-03 13:19:24 PST 
How annoying. I forgot to remove these IDLs from the XCode project. Now they are taunting me with redness.
Comment 4 Dimitri Glazkov (Google) 2009-03-03 13:20:59 PST 
Created attachment 28237 [details]
Remove IDLs from the project

 WebCore/ChangeLog                         |   10 ++++++++++
 WebCore/WebCore.xcodeproj/project.pbxproj |    8 --------
 2 files changed, 10 insertions(+), 8 deletions(-)
Comment 5 Dimitri Glazkov (Google) 2009-03-03 14:59:46 PST 
Project fix-up landed in http://trac.webkit.org/changeset/41408.