| Summary: | Make StructureMemoryManager alignment assert a RELEASE_ASSERT | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||
| Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Keith Miller
2022-02-13 11:41:02 PST
Created attachment 451831 [details]
Patch
Comment on attachment 451831 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451831&action=review r=me > Source/JavaScriptCore/heap/StructureAlignedMemoryAllocator.cpp:85 > + RELEASE_ASSERT(g_jscConfig.startOfStructureHeap && ((g_jscConfig.startOfStructureHeap & ~structureIDMask) == g_jscConfig.startOfStructureHeap)); let's also release assert it's not null. Comment on attachment 451831 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451831&action=review >> Source/JavaScriptCore/heap/StructureAlignedMemoryAllocator.cpp:85 >> + RELEASE_ASSERT(g_jscConfig.startOfStructureHeap && ((g_jscConfig.startOfStructureHeap & ~structureIDMask) == g_jscConfig.startOfStructureHeap)); > > let's also release assert it's not null. lol, I should read the code before commenting :-) Comment on attachment 451831 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451831&action=review >>> Source/JavaScriptCore/heap/StructureAlignedMemoryAllocator.cpp:85 >>> + RELEASE_ASSERT(g_jscConfig.startOfStructureHeap && ((g_jscConfig.startOfStructureHeap & ~structureIDMask) == g_jscConfig.startOfStructureHeap)); >> >> let's also release assert it's not null. > > lol, I should read the code before commenting :-) :P Committed r289717 (247202@main): <https://commits.webkit.org/247202@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451831 [details]. |