Bug 236560

Summary: [JSC] Fix test sharding when using --make-runner and --remote
Product: WebKit Reporter: Angelos Oikonomopoulos <angelos>
Component: New BugsAssignee: Angelos Oikonomopoulos <angelos>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, jbedard, mark.lam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Angelos Oikonomopoulos
Reported 2022-02-13 04:34:28 PST
[JSC] Fix test sharding when using --remote
Attachments
Patch (2.56 KB, patch)
2022-02-13 04:36 PST, Angelos Oikonomopoulos 		no flags
DetailsFormatted DiffDiff
Patch (2.83 KB, patch)
2022-02-15 07:21 PST, Angelos Oikonomopoulos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Angelos Oikonomopoulos
Comment 1 2022-02-13 04:36:48 PST
Created attachment 451814 [details] Patch
Angelos Oikonomopoulos
Comment 2 2022-02-15 07:21:55 PST
Created attachment 452020 [details] Patch
Angelos Oikonomopoulos
Comment 3 2022-02-15 12:17:47 PST
For reviewers who might be unfamiliar with ruby: @remoteHosts refers to an instance variable of the class (a field) and defaults to nil if the variable doesn't exist. The patch has prepareRunnerForRemote accept remoteHosts as an argument instead and updates all callers.
Angelos Oikonomopoulos
Comment 4 2022-02-15 12:21:00 PST
Oh, also to the best of my knowledge --make-runner is not used with --remote in any public buildbot.
EWS
Comment 5 2022-02-18 20:05:56 PST
Tools/Scripts/svn-apply failed to apply attachment 452020 [details] to trunk. Please resolve the conflicts and upload a new patch.
Radar WebKit Bug Importer
Comment 6 2022-02-20 04:35:15 PST
<rdar://problem/89202446>
Adrian Perez
Comment 8 2022-03-08 02:19:29 PST
Closing as fixed, because the patch has landed :)
Note You need to log in before you can comment on or make changes to this bug.