Bug 236542

Summary:

Use more references instead of never-null pointers in JavaScript bindings, cast to JSDOMGlobalObject at boundaries, simplify legacy plug-in and Objective-C binding code

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

WebCore Misc.

Assignee:

Darin Adler <darin>

Status:

ASSIGNED

Severity:

Normal

CC:

aakash_jain, alecflett, annulen, ashvayka, beidson, benjamin, calvaris, cdumez, changseok, cmarcelo, dino, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hi, hta, jbedard, jer.noble, jiewen_tan, joepeck, jsbell, kangil.han, keith_miller, kondapallykalyan, mark.lam, msaboff, pangle, philipj, ryuan.choi, saam, sergio, tommyw, tzagallo, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none

Darin Adler

Reported 2022-02-12 15:14:57 PST

Use more references instead of never-null pointers in JavaScript bindings, cast to JSDOMGlobalObject at boundaries, simplify legacy plug-in and Objective-C binding code

Attachments
Patch (1.39 MB, patch) 2022-02-12 15:22 PST, Darin Adler	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (4.41 MB, patch) 2022-02-13 10:46 PST, Darin Adler	no flags	Details Formatted Diff Diff
Patch (4.41 MB, patch) 2022-02-14 09:27 PST, Darin Adler	no flags	Details Formatted Diff Diff
Patch (4.41 MB, patch) 2022-02-16 13:23 PST, Darin Adler	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (4.41 MB, patch) 2022-02-16 15:20 PST, Darin Adler	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (4.41 MB, patch) 2022-02-16 16:29 PST, Darin Adler	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (4.41 MB, patch) 2022-02-16 21:18 PST, Darin Adler	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (4.41 MB, patch) 2022-02-17 01:13 PST, Darin Adler	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (4.41 MB, patch) 2022-02-17 08:59 PST, Darin Adler	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (4.41 MB, patch) 2022-02-17 11:02 PST, Darin Adler	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (4.41 MB, patch) 2022-02-17 15:27 PST, Darin Adler	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (4.42 MB, patch) 2022-02-17 19:45 PST, Darin Adler	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (4.42 MB, patch) 2022-02-18 13:00 PST, Darin Adler	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (4.42 MB, patch) 2022-02-21 12:34 PST, Darin Adler	no flags	Details Formatted Diff Diff
Patch (4.44 MB, patch) 2022-02-24 17:49 PST, Darin Adler	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (4.45 MB, patch) 2022-02-27 13:08 PST, Darin Adler	no flags	Details Formatted Diff Diff
Show Obsolete (15) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2022-02-12 15:22:20 PST Comment hidden (obsolete)

Created attachment 451796 [details] Patch

Darin Adler

Comment 2 2022-02-13 10:46:03 PST Comment hidden (obsolete)

Created attachment 451824 [details] Patch

Darin Adler

Comment 3 2022-02-14 09:27:09 PST Comment hidden (obsolete)

Created attachment 451913 [details] Patch

Darin Adler

Comment 4 2022-02-16 13:23:12 PST Comment hidden (obsolete)

Created attachment 452241 [details] Patch

Darin Adler

Comment 5 2022-02-16 15:20:41 PST Comment hidden (obsolete)

Created attachment 452256 [details] Patch

Darin Adler

Comment 6 2022-02-16 16:29:50 PST Comment hidden (obsolete)

Created attachment 452270 [details] Patch

Darin Adler

Comment 7 2022-02-16 21:18:23 PST Comment hidden (obsolete)

Created attachment 452309 [details] Patch

Darin Adler

Comment 8 2022-02-17 01:13:12 PST Comment hidden (obsolete)

Created attachment 452337 [details] Patch

Darin Adler

Comment 9 2022-02-17 08:52:22 PST

No way I am going to be able to land all of this at once, but I like the changes in it and will try to find a way to do them all.

Darin Adler

Comment 10 2022-02-17 08:59:39 PST Comment hidden (obsolete)

Created attachment 452377 [details] Patch

Darin Adler

Comment 11 2022-02-17 11:02:11 PST Comment hidden (obsolete)

Created attachment 452390 [details] Patch

Darin Adler

Comment 12 2022-02-17 15:27:10 PST Comment hidden (obsolete)

Created attachment 452439 [details] Patch

Darin Adler

Comment 13 2022-02-17 19:45:51 PST Comment hidden (obsolete)

Created attachment 452472 [details] Patch

Aakash Jain

Comment 14 2022-02-18 08:34:09 PST Comment hidden (obsolete)

I cancelled https://ews-build.webkit.org/#/builders/70/builds/657 to speed up mac-wk2 queue. It already finished running layout-tests (and indicated some failures).

Darin Adler

Comment 15 2022-02-18 13:00:21 PST Comment hidden (obsolete)

Created attachment 452566 [details] Patch

Radar WebKit Bug Importer

Comment 16 2022-02-19 15:15:27 PST

<rdar://problem/89192774>

Darin Adler

Comment 17 2022-02-21 12:34:01 PST Comment hidden (obsolete)

Created attachment 452758 [details] Patch

Darin Adler

Comment 18 2022-02-21 16:48:18 PST

Finally compiling on all platforms. Still got some crashes (most likely missing null-checks) to tix.

Jonathan Bedard

Comment 19 2022-02-22 07:26:32 PST Comment hidden (obsolete)

Canceled https://ews-build.webkit.org/#/builders/70/builds/966 because 3 of those failures are known, imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/sandbox_004.htm is not and likely caused by this change.

Aakash Jain

Comment 20 2022-02-23 13:37:07 PST Comment hidden (obsolete)

Also cancelled https://ews-build.webkit.org/#/builders/73/builds/805 to speed up mac-wk2 queue. It already finished running layout-tests and the failures seemed pre-existing.

Darin Adler

Comment 21 2022-02-24 17:49:19 PST Comment hidden (obsolete)

Created attachment 453160 [details] Patch

Darin Adler

Comment 22 2022-02-27 13:08:26 PST

Created attachment 453354 [details] Patch

Darin Adler

Comment 23 2022-02-27 15:12:55 PST

Looks like all tests are passing now. Time to break this up into smaller pieces to land it.

Note You need to log in before you can comment on or make changes to this bug.