| Summary: | Use more references instead of never-null pointers in JavaScript bindings, cast to JSDOMGlobalObject at boundaries, simplify legacy plug-in and Objective-C binding code | ||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||||||||||||||||||||||||||||||
| Component: | WebCore Misc. | Assignee: | Darin Adler <darin> | ||||||||||||||||||||||||||||||||||
| Status: | ASSIGNED --- | ||||||||||||||||||||||||||||||||||||
| Severity: | Normal | CC: | aakash_jain, alecflett, annulen, ashvayka, beidson, benjamin, calvaris, cdumez, changseok, cmarcelo, dino, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hi, hta, jbedard, jer.noble, jiewen_tan, joepeck, jsbell, kangil.han, keith_miller, kondapallykalyan, mark.lam, msaboff, pangle, philipj, ryuan.choi, saam, sergio, tommyw, tzagallo, webkit-bug-importer, youennf | ||||||||||||||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||||||||||
|
Description
Darin Adler
2022-02-12 15:14:57 PST
Created attachment 451796 [details]
Patch
Created attachment 451824 [details]
Patch
Created attachment 451913 [details]
Patch
Created attachment 452241 [details]
Patch
Created attachment 452256 [details]
Patch
Created attachment 452270 [details]
Patch
Created attachment 452309 [details]
Patch
Created attachment 452337 [details]
Patch
No way I am going to be able to land all of this at once, but I like the changes in it and will try to find a way to do them all. Created attachment 452377 [details]
Patch
Created attachment 452390 [details]
Patch
Created attachment 452439 [details]
Patch
Created attachment 452472 [details]
Patch
I cancelled https://ews-build.webkit.org/#/builders/70/builds/657 to speed up mac-wk2 queue. It already finished running layout-tests (and indicated some failures). Created attachment 452566 [details]
Patch
Created attachment 452758 [details]
Patch
Finally compiling on all platforms. Still got some crashes (most likely missing null-checks) to tix. Canceled https://ews-build.webkit.org/#/builders/70/builds/966 because 3 of those failures are known, imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/sandbox_004.htm is not and likely caused by this change. Also cancelled https://ews-build.webkit.org/#/builders/73/builds/805 to speed up mac-wk2 queue. It already finished running layout-tests and the failures seemed pre-existing. Created attachment 453160 [details]
Patch
Created attachment 453354 [details]
Patch
Looks like all tests are passing now. Time to break this up into smaller pieces to land it. |