Bug 236511

Summary: [iOS] Add a "Copy Cropped Image" context menu item when long pressing images
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: PlatformAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, benjamin, cdumez, cmarcelo, ews-watchlist, hi, katherine_cheney, megan_gardner, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 236519    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Try to fix Big Sur build
hi: review+
For landing none

Description Wenson Hsieh 2022-02-11 08:48:15 PST 
rdar://88817219
Comment 1 Wenson Hsieh 2022-02-11 11:12:56 PST Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2022-02-11 12:20:47 PST 
Created attachment 451735 [details]
Try to fix Big Sur build
Comment 3 Devin Rousso 2022-02-11 13:29:20 PST 
Comment on attachment 451735 [details]
Try to fix Big Sur build

View in context: https://bugs.webkit.org/attachment.cgi?id=451735&action=review

r=me, great work :)

> Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:559
> +            // FIXME: This should be additionally gated on the relevant VisionKit SPI.

bugzilla/radar?

> Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:595
> +        // FIXME: This should be additionally gated on the relevant VisionKit SPI.

ditto (:559)
Comment 4 Wenson Hsieh 2022-02-11 14:10:00 PST 
Comment on attachment 451735 [details]
Try to fix Big Sur build

View in context: https://bugs.webkit.org/attachment.cgi?id=451735&action=review

>> Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:559
>> +            // FIXME: This should be additionally gated on the relevant VisionKit SPI.
> 
> bugzilla/radar?

Good point — added a radar link.

>> Source/WebKit/UIProcess/ios/WKActionSheetAssistant.mm:595
>> +        // FIXME: This should be additionally gated on the relevant VisionKit SPI.
> 
> ditto (:559)

👍🏻
Comment 5 Wenson Hsieh 2022-02-11 14:43:03 PST 
Created attachment 451747 [details]
For landing
Comment 6 EWS 2022-02-11 17:13:18 PST 
Committed r289681 (247167@main): <https://commits.webkit.org/247167@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451747 [details].