Bug 236490

Summary:

ExtensionsGL is not useful class, it should be removed

Product:

WebKit

Reporter:

Kimmo Kinnunen <kkinnunen>

Component:

WebGL

Assignee:

Kimmo Kinnunen <kkinnunen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, cdumez, changseok, cmarcelo, dino, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, japhet, jer.noble, kbr, kkinnunen, kondapallykalyan, luiz, philipj, ryuan.choi, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

221664

Attachments:

Description	Flags
Patch	none
For EWS	ews-feeder: commit-queue-
For EWS	ews-feeder: commit-queue-
For EWS	ews-feeder: commit-queue-
For EWS	ews-feeder: commit-queue-
For EWS	ews-feeder: commit-queue-
For EWS	ews-feeder: commit-queue-
For EWS	ews-feeder: commit-queue-
For EWS	none
Patch	none

Kimmo Kinnunen

Reported 2022-02-11 00:06:44 PST

ExtensionsGL is not useful class, it should be removed It ends up just a complicated duplication of what is in GraphicsContextGL. Each contextgl type has has 1:1 hard-coded mapping to the extensiongl type. It causes problems because extensionsgl is needed during initialization of contextgl, in order to interact with the extension strings. This in turn is less-than-simple, since constructors calling virtual functions of the instance being constructed is complicated.

Attachments
Patch (269.62 KB, patch) 2022-02-11 00:51 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
For EWS (271.79 KB, patch) 2022-02-11 04:15 PST, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
For EWS (271.82 KB, patch) 2022-02-11 05:01 PST, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
For EWS (272.84 KB, patch) 2022-02-11 05:10 PST, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
For EWS (273.64 KB, patch) 2022-02-11 05:15 PST, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
For EWS (276.00 KB, patch) 2022-02-11 05:38 PST, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
For EWS (276.00 KB, patch) 2022-02-11 05:47 PST, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
For EWS (276.47 KB, patch) 2022-02-11 06:37 PST, Kimmo Kinnunen	ews-feeder: commit-queue-	Details Formatted Diff Diff
For EWS (277.82 KB, patch) 2022-02-11 07:10 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Patch (279.50 KB, patch) 2022-02-14 01:19 PST, Kimmo Kinnunen	no flags	Details Formatted Diff Diff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.