Bug 236490

Summary: ExtensionsGL is not useful class, it should be removed
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebGLAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, cdumez, changseok, cmarcelo, dino, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, japhet, jer.noble, kbr, kkinnunen, kondapallykalyan, luiz, philipj, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 221664    
Attachments:
Description Flags
Patch
none
For EWS
ews-feeder: commit-queue-
For EWS
ews-feeder: commit-queue-
For EWS
ews-feeder: commit-queue-
For EWS
ews-feeder: commit-queue-
For EWS
ews-feeder: commit-queue-
For EWS
ews-feeder: commit-queue-
For EWS
ews-feeder: commit-queue-
For EWS
none
Patch none

Description Kimmo Kinnunen 2022-02-11 00:06:44 PST 
ExtensionsGL is not useful class, it should be removed

It ends up just a complicated duplication of what is in GraphicsContextGL. Each contextgl type has  has 1:1 hard-coded mapping to the extensiongl type.

It causes problems because extensionsgl is needed during initialization of contextgl, in order to interact with the extension strings.
This in turn is less-than-simple, since constructors calling virtual functions of the instance being constructed is complicated.
Comment 1 Kimmo Kinnunen 2022-02-11 00:51:20 PST 
Created attachment 451653 [details]
Patch
Comment 2 Kimmo Kinnunen 2022-02-11 04:15:32 PST 
Created attachment 451674 [details]
For EWS
Comment 3 Kimmo Kinnunen 2022-02-11 05:01:34 PST 
Created attachment 451677 [details]
For EWS
Comment 4 Kimmo Kinnunen 2022-02-11 05:10:10 PST 
Created attachment 451678 [details]
For EWS
Comment 5 Kimmo Kinnunen 2022-02-11 05:15:31 PST 
Created attachment 451679 [details]
For EWS
Comment 6 Radar WebKit Bug Importer 2022-02-11 05:26:30 PST 
<rdar://problem/88811001>
Comment 7 Kimmo Kinnunen 2022-02-11 05:38:57 PST 
Created attachment 451680 [details]
For EWS
Comment 8 Kimmo Kinnunen 2022-02-11 05:47:50 PST 
Created attachment 451681 [details]
For EWS
Comment 9 Kimmo Kinnunen 2022-02-11 06:37:51 PST 
Created attachment 451686 [details]
For EWS
Comment 10 Kimmo Kinnunen 2022-02-11 07:10:01 PST 
Created attachment 451690 [details]
For EWS
Comment 11 Kimmo Kinnunen 2022-02-14 01:19:34 PST 
Created attachment 451873 [details]
Patch
Comment 12 EWS 2022-02-14 23:35:36 PST 
Committed r289790 (247255@main): <https://commits.webkit.org/247255@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451873 [details].