Bug 236479

Summary: Enable grammar checking on Mac Catalyst.
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, hi, mifenton, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch for landing none

Description Megan Gardner 2022-02-10 18:46:25 PST 
Enable grammar checking on Mac Catalyst.
Comment 1 Megan Gardner 2022-02-10 18:54:22 PST 
Created attachment 451627 [details]
Patch
Comment 2 Megan Gardner 2022-02-10 19:26:28 PST 
Created attachment 451632 [details]
Patch
Comment 3 Devin Rousso 2022-02-11 12:38:56 PST 
Comment on attachment 451632 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451632&action=review

r=mews, nice! :)

> Source/WebCore/platform/graphics/cocoa/GraphicsContextCocoa.mm:66
> +

Style: extra whitespace

> Source/WebKit/UIProcess/ios/TextCheckerIOS.mm:254
> +                    ASSERT(detailRangeAsNSValue);
> +                    NSRange detailNSRange = [detailRangeAsNSValue rangeValue];

Style: I'd maybe sprinkle some newlines in here so it's a bit less "wall-of-text"-y 😅

> Source/WebKit/UIProcess/ios/TextCheckerIOS.mm:261
> +                        detail.guesses.append(String(guess));

NIT: Is the `String` necessary?
Comment 4 Megan Gardner 2022-02-11 14:31:37 PST 
Created attachment 451745 [details]
Patch for landing
Comment 5 EWS 2022-02-11 15:04:34 PST 
Committed r289673 (247161@main): <https://commits.webkit.org/247161@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451745 [details].
Comment 6 Radar WebKit Bug Importer 2022-02-11 15:05:16 PST 
<rdar://problem/88837575>