Bug 236479

Summary: Enable grammar checking on Mac Catalyst.
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, hi, mifenton, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch for landing none

Megan Gardner
Reported 2022-02-10 18:46:25 PST
Enable grammar checking on Mac Catalyst.
Attachments
Patch (11.63 KB, patch)
2022-02-10 18:54 PST, Megan Gardner 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (11.63 KB, patch)
2022-02-10 19:26 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.70 KB, patch)
2022-02-11 14:31 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2022-02-10 18:54:22 PST
Created attachment 451627 [details] Patch
Megan Gardner
Comment 2 2022-02-10 19:26:28 PST
Created attachment 451632 [details] Patch
Devin Rousso
Comment 3 2022-02-11 12:38:56 PST
Comment on attachment 451632 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451632&action=review r=mews, nice! :) > Source/WebCore/platform/graphics/cocoa/GraphicsContextCocoa.mm:66 > + Style: extra whitespace > Source/WebKit/UIProcess/ios/TextCheckerIOS.mm:254 > + ASSERT(detailRangeAsNSValue); > + NSRange detailNSRange = [detailRangeAsNSValue rangeValue]; Style: I'd maybe sprinkle some newlines in here so it's a bit less "wall-of-text"-y 😅 > Source/WebKit/UIProcess/ios/TextCheckerIOS.mm:261 > + detail.guesses.append(String(guess)); NIT: Is the `String` necessary?
Megan Gardner
Comment 4 2022-02-11 14:31:37 PST
Created attachment 451745 [details] Patch for landing
EWS
Comment 5 2022-02-11 15:04:34 PST
Committed r289673 (247161@main): <https://commits.webkit.org/247161@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451745 [details].
Radar WebKit Bug Importer
Comment 6 2022-02-11 15:05:16 PST
<rdar://problem/88837575>
Note You need to log in before you can comment on or make changes to this bug.