Bug 236456

Summary:

Don't throw exception when controls are removed

Product:

WebKit

Reporter:

Enrique Ocaña <eocanha>

Component:

Media

Assignee:

Enrique Ocaña <eocanha>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

calvaris, eric.carlson, ews-watchlist, glenn, jer.noble, joepeck, philipj, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Enrique Ocaña 2022-02-10 11:02:02 PST

In mediaControlsBase.js, when media controls are removed, calling controlsAreHidden() can cause an exception because the panel has no parentElement.

Comment 1 Enrique Ocaña 2022-02-10 11:08:20 PST

Created attachment 451577 [details]
Patch

Comment 2 Xabier Rodríguez Calvar 2022-02-10 23:24:01 PST

Comment on attachment 451577 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451577&action=review

> Source/WebCore/ChangeLog:1
> +2022-02-10  Eugene Mutavchi  <Ievgen_Mutavchi@comcast.com>

You're responsible for this patch, your name should be here. Eugene's one is already in below.

> Source/WebCore/ChangeLog:3
> +        Don't throw exception when controls are hidden

If the crash happens because controls are removed, then this title is misleading.

Comment 3 Enrique Ocaña 2022-02-11 02:58:14 PST

Created attachment 451666 [details]
Patch

Comment 4 EWS 2022-02-14 04:21:55 PST

Committed r289730 (247215@main): <https://commits.webkit.org/247215@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451666 [details].

Comment 5 Radar WebKit Bug Importer 2022-02-14 04:22:19 PST

<rdar://problem/88898131>