Bug 236456

Summary: Don't throw exception when controls are removed
Product: WebKit Reporter: Enrique Ocaña <eocanha>
Component: MediaAssignee: Enrique Ocaña <eocanha>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, eric.carlson, ews-watchlist, glenn, jer.noble, joepeck, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Enrique Ocaña
Reported 2022-02-10 11:02:02 PST
In mediaControlsBase.js, when media controls are removed, calling controlsAreHidden() can cause an exception because the panel has no parentElement.
Attachments
Patch (1.71 KB, patch)
2022-02-10 11:08 PST, Enrique Ocaña 		no flags
DetailsFormatted DiffDiff
Patch (1.72 KB, patch)
2022-02-11 02:58 PST, Enrique Ocaña 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Enrique Ocaña
Comment 1 2022-02-10 11:08:20 PST
Created attachment 451577 [details] Patch
Xabier Rodríguez Calvar
Comment 2 2022-02-10 23:24:01 PST
Comment on attachment 451577 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451577&action=review > Source/WebCore/ChangeLog:1 > +2022-02-10 Eugene Mutavchi <Ievgen_Mutavchi@comcast.com> You're responsible for this patch, your name should be here. Eugene's one is already in below. > Source/WebCore/ChangeLog:3 > + Don't throw exception when controls are hidden If the crash happens because controls are removed, then this title is misleading.
Enrique Ocaña
Comment 3 2022-02-11 02:58:14 PST
Created attachment 451666 [details] Patch
EWS
Comment 4 2022-02-14 04:21:55 PST
Committed r289730 (247215@main): <https://commits.webkit.org/247215@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451666 [details].
Radar WebKit Bug Importer
Comment 5 2022-02-14 04:22:19 PST
<rdar://problem/88898131>
Note You need to log in before you can comment on or make changes to this bug.