Bug 236441

Summary: Make MIMETypeRegistry::mimeTypeForPath take a StringView
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: Web Template FrameworkAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, ews-watchlist, hi, japhet, joepeck, mifenton, pangle, webkit-bug-importer, youennf
Priority: P2 Keywords: EasyFix, GoodFirstBug, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Tim Nguyen (:ntim)
Reported 2022-02-10 07:01:33 PST
So we don't need an expensive call to toString()
Attachments
Patch (3.66 KB, patch)
2022-03-14 04:09 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (16.27 KB, patch)
2022-03-15 01:36 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (16.21 KB, patch)
2022-03-16 03:26 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-02-17 07:02:16 PST
<rdar://problem/89084526>
youenn fablet
Comment 2 2022-03-14 04:09:34 PDT
Created attachment 454576 [details] Patch
Chris Dumez
Comment 3 2022-03-14 07:11:15 PDT
Comment on attachment 454576 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454576&action=review > Source/WebCore/platform/MIMETypeRegistry.cpp:402 > + auto result = mimeTypeForExtension(path.substring(position + 1).toString()); Seems we could go one step further and make mimeTypeForExtension() take a StringView too?
youenn fablet
Comment 4 2022-03-15 01:26:47 PDT
Comment on attachment 454576 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454576&action=review >> Source/WebCore/platform/MIMETypeRegistry.cpp:402 >> + auto result = mimeTypeForExtension(path.substring(position + 1).toString()); > > Seems we could go one step further and make mimeTypeForExtension() take a StringView too? I thought about it and did not do it as it is a bigger/cross-platform change. I'll give it a try.
youenn fablet
Comment 5 2022-03-15 01:36:44 PDT
Created attachment 454679 [details] Patch
Chris Dumez
Comment 6 2022-03-15 07:14:12 PDT
Comment on attachment 454679 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454679&action=review r=me with fix. > Source/WebCore/platform/MIMETypeRegistry.cpp:402 > + auto result = mimeTypeForExtension(path.substring(position + 1).toString()); There should be no .toString() here.
youenn fablet
Comment 7 2022-03-16 03:26:45 PDT
Created attachment 454817 [details] Patch for landing
EWS
Comment 8 2022-03-16 05:55:16 PDT
Committed r291341 (248480@main): <https://commits.webkit.org/248480@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 454817 [details].
Note You need to log in before you can comment on or make changes to this bug.