Bug 236408

Summary: Use Ref<> for getBackground/MaskShorthandValue
Product: WebKit Reporter: Matt Woodrow <mattwoodrow>
Component: CSSAssignee: Matt Woodrow <mattwoodrow>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, ntim, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Matt Woodrow
Reported 2022-02-09 14:14:17 PST
These can never return nullptr, so we should use Ref.
Attachments
Patch (4.67 KB, patch)
2022-02-09 14:15 PST, Matt Woodrow 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matt Woodrow
Comment 1 2022-02-09 14:15:55 PST
Created attachment 451442 [details] Patch
Tim Nguyen (:ntim)
Comment 2 2022-02-10 12:16:43 PST
Comment on attachment 451442 [details] Patch LGTM! EWS is green too.
EWS
Comment 3 2022-02-10 15:38:13 PST
Committed r289588 (247101@main): <https://commits.webkit.org/247101@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451442 [details].
Radar WebKit Bug Importer
Comment 4 2022-02-10 15:39:16 PST
<rdar://problem/88782405>
Note You need to log in before you can comment on or make changes to this bug.