Bug 236364

Summary: [WebAuthn] Modify getAllLocalAuthenticatorCredentials according to internal needs
Product: WebKit Reporter: pascoe <pascoe>
Component: WebKit Misc.Assignee: pascoe <pascoe>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Description pascoe@apple.com 2022-02-09 07:14:47 PST 
^
Comment 1 pascoe@apple.com 2022-02-09 07:14:58 PST 
rdar://88585418
Comment 2 pascoe@apple.com 2022-02-09 07:18:03 PST 
Created attachment 451371 [details]
Patch
Comment 3 pascoe@apple.com 2022-02-09 13:47:19 PST 
Created attachment 451440 [details]
Patch
Comment 4 pascoe@apple.com 2022-02-09 16:46:11 PST 
Created attachment 451459 [details]
Patch
Comment 5 Brent Fulgham 2022-02-11 10:48:26 PST 
Comment on attachment 451459 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451459&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:348
> ++ (void)setUsernameForLocalCredentialWithGroup:(NSString *)group credential:(NSData *)credentialID username: (NSString *)username

Nit: I think we would usually name this something like 'setUsernameForLocalCredentialWithGroupAndID:'

> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:553
> ++ (NSData *)exportLocalAuthenticatorCredentialWithGroup:(NSString *)group credential:(NSData *)credentialID error:(NSError **)error

Ditto: "WithGroupAndID"
Comment 6 pascoe@apple.com 2022-02-14 09:49:57 PST 
Created attachment 451918 [details]
Patch for landing
Comment 7 EWS 2022-02-15 09:05:08 PST 
Committed r289817 (247278@main): <https://commits.webkit.org/247278@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451918 [details].