| Summary: | Allow hanging run-javascriptcore-tests to print backtrace | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Angelos Oikonomopoulos <angelos> | ||||
| Component: | New Bugs | Assignee: | Angelos Oikonomopoulos <angelos> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, cgarcia, ews-watchlist, jbedard, ryanhaddad, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Angelos Oikonomopoulos
2022-02-09 02:06:59 PST
Created attachment 451350 [details]
Patch
I'm interested in seeing how the output looks like in practice when sigtermTime is used. Do you have an example, maybe from ews? (In reply to Aakash Jain from comment #2) > I'm interested in seeing how the output looks like in practice when > sigtermTime is used. Do you have an example, maybe from ews? Sure! See jscore-test in https://ews-build.webkit.org/#/builders/45/builds/9028. Comment on attachment 451350 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451350&action=review > Tools/CISupport/build-webkit-org/steps.py:467 > + if 'sigtermTime' not in kwargs: Not sure if you had specific reason for guarding with this if condition, could have skipped if condition as well. Either way is fine though. No specific reason, just allowing the caller to override the value if necessary. Committed r289468 (247011@main): <https://commits.webkit.org/247011@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451350 [details]. |