| Summary: | Non-unified build fixes after r289247 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Lauro Moura <lmoura> | ||||||||
| Component: | New Bugs | Assignee: | Lauro Moura <lmoura> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aboxhall, andresg_22, apinheiro, bugs-noreply, cfleizach, dmazzoni, ews-watchlist, Hironori.Fujii, jcraig, jdiggs, keith_miller, mark.lam, msaboff, saam, samuel_white, tzagallo, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Lauro Moura
2022-02-08 18:21:50 PST
Created attachment 451332 [details]
Patch
Comment on attachment 451332 [details]
Patch
Needs rebase
Created attachment 451333 [details]
rebased patch
Comment on attachment 451333 [details] rebased patch View in context: https://bugs.webkit.org/attachment.cgi?id=451333&action=review > Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp:36 > #include <WebCore/RegistrableDomain.h> You add <WebCore/RegistrableDomain.h> in WebSharedWorkerServer.h. We can remove <WebCore/RegistrableDomain.h> here too. > Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServer.h:35 > +#include <pal/SessionID.h> Do you need to include this? If so, you should remove the forward declaration of SessionID below. Comment on attachment 451333 [details] rebased patch View in context: https://bugs.webkit.org/attachment.cgi?id=451333&action=review > Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.h:32 > +#include <WebCore/TransferredMessagePort.h> TransferredMessagePort is used only in arguments. I think we should add a forward declaration in this case. Created attachment 451361 [details]
Patch for landing
(In reply to Fujii Hironori from comment #5) > Comment on attachment 451333 [details] > rebased patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=451333&action=review > > > Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.h:32 > > +#include <WebCore/TransferredMessagePort.h> > > TransferredMessagePort is used only in arguments. I think we should add a > forward declaration in this case. I needed to include it directly as it's an alias to a `std::pair`. Committed r289469 (247012@main): <https://commits.webkit.org/247012@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451361 [details]. |