Bug 236343

Summary: Non-unified build fixes after r289247
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: New BugsAssignee: Lauro Moura <lmoura>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, bugs-noreply, cfleizach, dmazzoni, ews-watchlist, fujii.hironori, jcraig, jdiggs, keith_miller, mark.lam, msaboff, saam, samuel_white, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
rebased patch
none
Patch for landing ews-feeder: commit-queue-

Lauro Moura
Reported 2022-02-08 18:21:50 PST
Non-unified build fixes after r289247
Attachments
Patch (11.10 KB, patch)
2022-02-08 18:22 PST, Lauro Moura 		no flags
DetailsFormatted DiffDiff
rebased patch (10.25 KB, patch)
2022-02-08 18:32 PST, Lauro Moura 		no flags
DetailsFormatted DiffDiff
Patch for landing (10.16 KB, patch)
2022-02-09 05:27 PST, Lauro Moura 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Lauro Moura
Comment 1 2022-02-08 18:22:52 PST
Created attachment 451332 [details] Patch
Lauro Moura
Comment 2 2022-02-08 18:26:56 PST
Comment on attachment 451332 [details] Patch Needs rebase
Lauro Moura
Comment 3 2022-02-08 18:32:10 PST
Created attachment 451333 [details] rebased patch
Fujii Hironori
Comment 4 2022-02-08 20:14:06 PST
Comment on attachment 451333 [details] rebased patch View in context: https://bugs.webkit.org/attachment.cgi?id=451333&action=review > Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServer.cpp:36 > #include <WebCore/RegistrableDomain.h> You add <WebCore/RegistrableDomain.h> in WebSharedWorkerServer.h. We can remove <WebCore/RegistrableDomain.h> here too. > Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServer.h:35 > +#include <pal/SessionID.h> Do you need to include this? If so, you should remove the forward declaration of SessionID below.
Fujii Hironori
Comment 5 2022-02-08 20:19:37 PST
Comment on attachment 451333 [details] rebased patch View in context: https://bugs.webkit.org/attachment.cgi?id=451333&action=review > Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.h:32 > +#include <WebCore/TransferredMessagePort.h> TransferredMessagePort is used only in arguments. I think we should add a forward declaration in this case.
Lauro Moura
Comment 6 2022-02-09 05:27:27 PST
Created attachment 451361 [details] Patch for landing
Lauro Moura
Comment 7 2022-02-09 05:30:50 PST
(In reply to Fujii Hironori from comment #5) > Comment on attachment 451333 [details] > rebased patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=451333&action=review > > > Source/WebKit/NetworkProcess/SharedWorker/WebSharedWorkerServerConnection.h:32 > > +#include <WebCore/TransferredMessagePort.h> > > TransferredMessagePort is used only in arguments. I think we should add a > forward declaration in this case. I needed to include it directly as it's an alias to a `std::pair`.
EWS
Comment 8 2022-02-09 07:14:41 PST
Committed r289469 (247012@main): <https://commits.webkit.org/247012@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451361 [details].
Radar WebKit Bug Importer
Comment 9 2022-02-09 07:15:30 PST
<rdar://problem/88688041>
Note You need to log in before you can comment on or make changes to this bug.