Bug 236305

Summary: ImageBuffer::get/putPixelBuffer should not go through DisplayList
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: CanvasAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ggaren, jonlee, mmaxfield, sabouhallawa, sam, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=240802
Bug Depends on: 236744, 240802    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Kimmo Kinnunen 2022-02-08 08:31:04 PST 
ImageBuffer::get/putPixelBuffer should not go through DisplayList
Comment 1 Kimmo Kinnunen 2022-02-08 08:59:20 PST 
Created attachment 451256 [details]
Patch
Comment 2 Sam Weinig 2022-02-08 10:06:29 PST 
Comment on attachment 451256 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451256&action=review

> Source/WebCore/ChangeLog:9
> +        Remove GetPixelBuffer / PutPixelBuffer from display list implementation.
> +        Display lists are about GraphicsContext commands.

Awesome!
Comment 3 Geoffrey Garen 2022-02-08 10:16:29 PST 
Comment on attachment 451256 [details]
Patch

r=me

Any way to add a test for the inverted references case?
Comment 4 Kimmo Kinnunen 2022-02-08 11:05:13 PST 
(In reply to Geoffrey Garen from comment #3)
> Comment on attachment 451256 [details]
> Patch
> 
> r=me
> 
> Any way to add a test for the inverted references case?

Currently there's no such things, as read and write references are not tracked in that way. I'm working on adding these after https://bugs.webkit.org/show_bug.cgi?id=236099
Comment 5 Radar WebKit Bug Importer 2022-02-09 22:10:39 PST 
<rdar://problem/88735790>
Comment 6 EWS 2022-02-10 14:50:13 PST 
Committed r289580 (247097@main): <https://commits.webkit.org/247097@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 451256 [details].