Bug 23630

Summary: Codereview: Skia complex font rendering
Product: WebKit Reporter: Sverrir Á. Berg <sverrir>
Component: New BugsAssignee: Sverrir Á. Berg <sverrir>
Status: RESOLVED FIXED    
Severity: Normal CC: brettw, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
Patch eric: review+

Sverrir Á. Berg
Reported 2009-01-29 15:40:44 PST
Add complex font rendering using Skia instead of Windows ScriptTextOut. This adds support for enhanced webkit styles when drawing complex glyphs.
Attachments
Patch (21.39 KB, patch)
2009-01-29 15:42 PST, Sverrir Á. Berg 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sverrir Á. Berg
Comment 1 2009-01-29 15:42:51 PST
Created attachment 27168 [details] Patch
Eric Seidel (no email)
Comment 2 2009-01-29 16:06:58 PST
I'd like to see Brett's comments on this before any of us WebKit dev's r+ this. (maybe brett has already reviewed this in chromium's repo?)
Brett Wilson (Google)
Comment 3 2009-01-29 22:13:32 PST
I already reviewed this. I don't think it's a complete solution for complex scripts and effects, but is better than what we have now and should cover 90% of the cases.
Sverrir Á. Berg
Comment 4 2009-02-05 11:34:38 PST
ping?
Eric Seidel (no email)
Comment 5 2009-02-05 11:39:04 PST
Comment on attachment 27168 [details] Patch Brett likes it. It's fine with me.
Sverrir Á. Berg
Comment 6 2009-02-06 11:36:51 PST
Eric: Could you please land/commit this for me? Thanks, Sverrir
Darin Fisher (:fishd, Google)
Comment 7 2009-02-10 00:34:42 PST
Landed here: http://trac.webkit.org/changeset/40812
Note You need to log in before you can comment on or make changes to this bug.