Bug 236266

Summary:	[ews] Do not configure GitHub hooks on local testing instance
Product:	WebKit	Reporter:	Aakash Jain <aakash_jain>
Component:	Tools / Tests	Assignee:	Aakash Jain <aakash_jain>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	aakash_jain, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Aakash Jain

Reported 2022-02-07 15:26:59 PST

We don't need to configure GitHub hooks on local testing instance of EWS. This also results in following unnecessary warning in logs (e.g.: in https://ews-build.webkit.org/#/builders/20/builds/67358/steps/15/logs/stdio): Error in finding GITHUB_HOOK_SECRET in passwords.json Error in finding GITHUB_COM_ACCESS_TOKEN in passwords.json

Attachments
Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2022-02-07 15:31:11 PST

Pull Request: https://github.com/WebKit/WebKit/pull/129

Aakash Jain

Comment 2 2022-02-08 04:04:54 PST

Landed https://commits.webkit.org/246952@main (899137b)!

Radar WebKit Bug Importer

Comment 3 2022-02-08 04:05:21 PST

<rdar://problem/88622362>

Note You need to log in before you can comment on or make changes to this bug.