Bug 236266 - [ews] Do not configure GitHub hooks on local testing instance
Summary: [ews] Do not configure GitHub hooks on local testing instance
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-07 15:26 PST by Aakash Jain
Modified: 2022-02-08 04:05 PST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2022-02-07 15:26:59 PST
We don't need to configure GitHub hooks on local testing instance of EWS.

This also results in following unnecessary warning in logs (e.g.: in https://ews-build.webkit.org/#/builders/20/builds/67358/steps/15/logs/stdio):
Error in finding GITHUB_HOOK_SECRET in passwords.json
Error in finding GITHUB_COM_ACCESS_TOKEN in passwords.json
Comment 1 Aakash Jain 2022-02-07 15:31:11 PST
Pull Request: https://github.com/WebKit/WebKit/pull/129
Comment 2 Aakash Jain 2022-02-08 04:04:54 PST
Landed https://commits.webkit.org/246952@main (899137b)!
Comment 3 Radar WebKit Bug Importer 2022-02-08 04:05:21 PST
<rdar://problem/88622362>