Summary: | [JSC] Convert JSString's non-atomic WTF::String to atomic string while concurrent compilers / heap threads run | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, sam, tzagallo, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Yusuke Suzuki
2022-02-07 14:38:25 PST
Created attachment 451156 [details]
Patch
Comment on attachment 451156 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451156&action=review > Source/JavaScriptCore/ChangeLog:3 > + [JSC] Convert JSString's non-atomic WTF::String to atomic string while concurrent compilers / heap threads run Alas, it is now called AtomString, not AtomicString. > Source/JavaScriptCore/ChangeLog:8 > + Inspired from Cameron's change. This patch introduces a new protocol which allows us to replace JSString's underlying non-atomic String Which change are you referring to here (I don't know, and in the future those reading this surely will not know). Comment on attachment 451156 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451156&action=review >> Source/JavaScriptCore/ChangeLog:8 >> + Inspired from Cameron's change. This patch introduces a new protocol which allows us to replace JSString's underlying non-atomic String > > Which change are you referring to here (I don't know, and in the future those reading this surely will not know). This one https://trac.webkit.org/changeset/289177/webkit. Comment on attachment 451156 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451156&action=review r=me >>> Source/JavaScriptCore/ChangeLog:8 >>> + Inspired from Cameron's change. This patch introduces a new protocol which allows us to replace JSString's underlying non-atomic String >> >> Which change are you referring to here (I don't know, and in the future those reading this surely will not know). > > This one https://trac.webkit.org/changeset/289177/webkit. I'd link it here in the changelog or just write r289177 OK, changed :) Committed r289359 (246947@trunk): <https://commits.webkit.org/246947@trunk> |