Bug 236262

Summary: [JSC] Convert JSString's non-atomic WTF::String to atomic string while concurrent compilers / heap threads run
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, sam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch saam: review+

Yusuke Suzuki
Reported 2022-02-07 14:38:25 PST
[JSC] Convert JSString's non-atomic WTF::String to atomic string while concurrent compilers / heap threads run
Attachments
Patch (16.95 KB, patch)
2022-02-07 14:55 PST, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2022-02-07 14:55:48 PST
Created attachment 451156 [details] Patch
Sam Weinig
Comment 2 2022-02-07 16:35:03 PST
Comment on attachment 451156 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451156&action=review > Source/JavaScriptCore/ChangeLog:3 > + [JSC] Convert JSString's non-atomic WTF::String to atomic string while concurrent compilers / heap threads run Alas, it is now called AtomString, not AtomicString. > Source/JavaScriptCore/ChangeLog:8 > + Inspired from Cameron's change. This patch introduces a new protocol which allows us to replace JSString's underlying non-atomic String Which change are you referring to here (I don't know, and in the future those reading this surely will not know).
Yusuke Suzuki
Comment 3 2022-02-07 17:28:39 PST
Comment on attachment 451156 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451156&action=review >> Source/JavaScriptCore/ChangeLog:8 >> + Inspired from Cameron's change. This patch introduces a new protocol which allows us to replace JSString's underlying non-atomic String > > Which change are you referring to here (I don't know, and in the future those reading this surely will not know). This one https://trac.webkit.org/changeset/289177/webkit.
Saam Barati
Comment 4 2022-02-07 18:10:19 PST
Comment on attachment 451156 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451156&action=review r=me >>> Source/JavaScriptCore/ChangeLog:8 >>> + Inspired from Cameron's change. This patch introduces a new protocol which allows us to replace JSString's underlying non-atomic String >> >> Which change are you referring to here (I don't know, and in the future those reading this surely will not know). > > This one https://trac.webkit.org/changeset/289177/webkit. I'd link it here in the changelog or just write r289177
Yusuke Suzuki
Comment 5 2022-02-07 21:43:21 PST
OK, changed :)
Yusuke Suzuki
Comment 6 2022-02-07 21:47:21 PST
Committed r289359 (246947@trunk): <https://commits.webkit.org/246947@trunk>
Radar WebKit Bug Importer
Comment 7 2022-02-07 21:48:21 PST
<rdar://problem/88611548>
Note You need to log in before you can comment on or make changes to this bug.