Bug 236251

Summary:

[Xcode] Prevent install builds from using the default toolchain

Product:

WebKit

Reporter:

Elliott Williams <emw>

Component:

New Bugs

Assignee:

Elliott Williams <emw>

Status:

RESOLVED MOVED

Severity:

Normal

CC:

ap, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Elliott Williams 2022-02-07 12:09:49 PST

[Xcode] Prevent install builds from using the default toolchain

Comment 1 Elliott Williams 2022-02-07 12:14:12 PST

Created attachment 451137 [details]
Patch

Comment 2 Radar WebKit Bug Importer 2022-02-07 12:15:13 PST

<rdar://problem/88587680>

Comment 3 Elliott Williams 2022-02-07 12:17:22 PST

Comment on attachment 451137 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451137&action=review

> Source/WTF/WTF.xcodeproj/project.pbxproj:1761
> +			shellScript = "if [ $(basename \"$TOOLCHAIN_DIR\") == \"XcodeDefault.xctoolchain\" ]; then\necho \"error: Installed toolchain doesn't match requested one, failing the build early to prevent falling back to default toolchain\"\nexit 1\nfi\n";

this is:
```
if [ $(basename "$TOOLCHAIN_DIR") == "XcodeDefault.xctoolchain" ]; then
echo "error: Installed toolchain doesn't match requested one, failing the build early to prevent falling back to default toolchain"
exit 1
fi
```

Comment 4 Alexey Proskuryakov 2022-02-07 13:32:29 PST

Comment on attachment 451137 [details]
Patch

Moving this elsewhere.