| Summary: | Update hover state based on pointer type. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Megan Gardner <megan_gardner> | ||||||||
| Component: | New Bugs | Assignee: | Megan Gardner <megan_gardner> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cdumez, changseok, cmarcelo, esprehn+autocc, ews-watchlist, gyuyoung.kim, kangil.han, mifenton, thorton, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Megan Gardner
2022-02-07 11:25:40 PST
Created attachment 451128 [details]
Patch
Created attachment 451138 [details]
Patch
Comment on attachment 451138 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451138&action=review > Source/WebCore/dom/Element.h:346 > + virtual void setHovered(bool = true, Style::InvalidationScope = Style::InvalidationScope::All, HitTestRequest = HitTestRequest()); { } > Source/WebCore/html/HTMLTextFormControlElement.cpp:73 > + UNUSED_PARAM(request); can just drop the argument names instead of UNUSED_PARAM (applies in a bunch of places) > Source/WebCore/html/HTMLTextFormControlElement.cpp:128 > + // Update our status first. Do not think this comment is necessary (maybe if it said why, but since it doesn't, get rid of it). > Source/WebKit/UIProcess/ios/WKMouseGestureRecognizer.mm:148 > +- (bool)checkTouches:(NSSet<UITouch *> *)touches Don't think you need this anymore? Created attachment 451152 [details]
Patch for landing
Committed r289246 (246930@main): <https://commits.webkit.org/246930@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451152 [details]. |