Bug 236249

Summary: Update hover state based on pointer type.
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, cmarcelo, esprehn+autocc, ews-watchlist, gyuyoung.kim, kangil.han, mifenton, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch for landing none

Megan Gardner
Reported 2022-02-07 11:25:40 PST
Update hover state based on pointer type.
Attachments
Patch (15.07 KB, patch)
2022-02-07 11:28 PST, Megan Gardner 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (15.08 KB, patch)
2022-02-07 12:18 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch for landing (14.63 KB, patch)
2022-02-07 14:28 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2022-02-07 11:28:18 PST
Created attachment 451128 [details] Patch
Megan Gardner
Comment 2 2022-02-07 12:18:14 PST
Created attachment 451138 [details] Patch
Tim Horton
Comment 3 2022-02-07 14:07:50 PST
Comment on attachment 451138 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451138&action=review > Source/WebCore/dom/Element.h:346 > + virtual void setHovered(bool = true, Style::InvalidationScope = Style::InvalidationScope::All, HitTestRequest = HitTestRequest()); { } > Source/WebCore/html/HTMLTextFormControlElement.cpp:73 > + UNUSED_PARAM(request); can just drop the argument names instead of UNUSED_PARAM (applies in a bunch of places) > Source/WebCore/html/HTMLTextFormControlElement.cpp:128 > + // Update our status first. Do not think this comment is necessary (maybe if it said why, but since it doesn't, get rid of it). > Source/WebKit/UIProcess/ios/WKMouseGestureRecognizer.mm:148 > +- (bool)checkTouches:(NSSet<UITouch *> *)touches Don't think you need this anymore?
Megan Gardner
Comment 4 2022-02-07 14:28:12 PST
Created attachment 451152 [details] Patch for landing
EWS
Comment 5 2022-02-07 15:18:47 PST
Committed r289246 (246930@main): <https://commits.webkit.org/246930@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451152 [details].
Radar WebKit Bug Importer
Comment 6 2022-02-07 15:19:16 PST
<rdar://problem/88597170>
Note You need to log in before you can comment on or make changes to this bug.