Bug 236244

Summary: No animation when scroll snap scroller is navigated with the keyboard
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: ScrollingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, pdr, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: BrowserCompat, InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=234456
Attachments:
Description Flags
Patch
thorton: review+, ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch none

Description Simon Fraser (smfr) 2022-02-07 08:49:46 PST 
https://css-tricks.com/css-scroll-snap-slide-deck/ describes a slide deck using scroll snap for the slides. In the result <https://codepen.io/5t3ph/full/yLzQeGr/652097fa9ce1150aeb5400637ab91b63>, moving between slides via the keyboard doesn't animate in Safari, but odes in Chrome and Firefox.
Comment 1 Radar WebKit Bug Importer 2022-02-07 08:50:12 PST 
<rdar://problem/88574200>
Comment 2 Simon Fraser (smfr) 2022-02-25 17:19:35 PST 
Created attachment 453279 [details]
Patch
Comment 3 Simon Fraser (smfr) 2022-02-26 10:43:28 PST 
https://trac.webkit.org/changeset/290548/webkit
Comment 4 Simon Fraser (smfr) 2022-02-28 10:07:21 PST 
Reverted in https://trac.webkit.org/changeset/290604/webkit
Comment 5 Simon Fraser (smfr) 2022-02-28 10:12:48 PST 
Created attachment 453402 [details]
Patch
Comment 6 Simon Fraser (smfr) 2022-02-28 12:10:52 PST 
I think the tests are passing for me because the default value for ScrollAnimatorEnabled comes from the NSScrollAnimationEnabled default.
Comment 7 Simon Fraser (smfr) 2022-02-28 12:38:56 PST 
Also NSScrollAnimationEnabled is 1 when read in the web process, and 0 when read in the UI process (when there's a stale default left around)
Comment 8 Simon Fraser (smfr) 2022-02-28 14:41:36 PST 
Created attachment 453433 [details]
Patch
Comment 9 EWS 2022-02-28 19:01:24 PST 
Committed r290625 (247898@main): <https://commits.webkit.org/247898@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453433 [details].