| Summary: | [model] improve sizing on iOS | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||
| Component: | New Bugs | Assignee: | Antoine Quint <graouts> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | darin, dino, thorton, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 236233 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Antoine Quint
2022-02-07 06:55:27 PST
Created attachment 451094 [details]
Patch
Comment on attachment 451094 [details]
Patch
Any way to test this?
(In reply to Dean Jackson from comment #3) > Comment on attachment 451094 [details] > Patch > > Any way to test this? This sets the size in ways that are internal to ARQL, I don't think we can test this. To state something we have learned over the years on the WebKit project: If we want to keep this working we have to figure out some way to regression test. Even if it involves thinking creatively and adding new test hooks of some kind. Otherwise it just breaks some day without anyone noticing. I'll engage with the right people internally to see how we could test this correctly. I think we might be able to cook something up with empty model resources and turning on debug colors on ASVInlinePreview instances which should allow us to have predictable renderings to test against. Committed r289235 (246919@main): <https://commits.webkit.org/246919@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451094 [details]. |