Bug 236220

Summary: Refactor RenderLayer::scrollRectToVisible
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: ScrollingAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, annulen, apinheiro, cdumez, cfleizach, changseok, cmarcelo, dmazzoni, esprehn+autocc, ews-watchlist, fred.wang, glenn, gyuyoung.kim, jcraig, jdiggs, kangil.han, kondapallykalyan, mifenton, pdr, ryuan.choi, samuel_white, sergio, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch none

Martin Robinson
Reported 2022-02-07 01:17:29 PST
RenderLayer::scrollRectToVisible has three different paths including one for RenderLayers that scroll, one for top-level FrameViews, and one for child FrameViews. The combined complexity of the three paths makes the method quite large and hard to understand. This bug tracks refactoring the logic so that it's easier to understand.
Attachments
Patch (87.41 KB, patch)
2022-02-07 07:12 PST, Martin Robinson 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (87.42 KB, patch)
2022-02-07 08:31 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (87.43 KB, patch)
2022-02-08 01:09 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (87.42 KB, patch)
2022-02-08 10:51 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (87.44 KB, patch)
2022-02-09 05:27 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2022-02-07 07:12:35 PST
Created attachment 451093 [details] Patch
Martin Robinson
Comment 2 2022-02-07 08:31:30 PST
Created attachment 451109 [details] Patch
Martin Robinson
Comment 3 2022-02-08 01:09:35 PST
Created attachment 451219 [details] Patch
Martin Robinson
Comment 4 2022-02-08 10:51:44 PST
Created attachment 451275 [details] Patch
Martin Robinson
Comment 5 2022-02-09 05:27:37 PST
Created attachment 451362 [details] Patch
Martin Robinson
Comment 6 2022-02-10 06:30:01 PST
Comment on attachment 451362 [details] Patch Okay. After fighting with the CI, I think this patch is ready for review. :)
Radar WebKit Bug Importer
Comment 7 2022-02-14 01:18:16 PST
<rdar://problem/88893284>
Martin Robinson
Comment 8 2022-05-27 01:20:21 PDT
Pull request: https://github.com/WebKit/WebKit/pull/1088
EWS
Comment 9 2022-07-19 03:00:25 PDT
Committed 252595@main (ba34b343955e): <https://commits.webkit.org/252595@main> Reviewed commits have been landed. Closing PR #1088 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.