Bug 236187

Summary: [LBSE] Apply position / size to SVG layers
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, pdr, rbuis, sabouhallawa, simon.fraser, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 90738, 236194    
Attachments:
Description Flags
Patch, v1
none
Patch, v2 rbuis: review+

Description Nikolas Zimmermann 2022-02-05 16:24:37 PST 
Prepare RenderLayer/RenderLayerBacking for RenderSVGModelObject support:

Teach RenderLayer::updateLayerPosition() about RenderSVGModelObject derived renderers that create layers.
Grab size and position information from the SVG render tree, just as done for CSS boxes in the render tree.
Comment 1 Nikolas Zimmermann 2022-02-05 16:40:19 PST 
Created attachment 451012 [details]
Patch, v1
Comment 2 Nikolas Zimmermann 2022-02-06 03:00:01 PST 
Revisiting the whole patch series I noticed this is one of the few places still using the renderer().isRenderSVGModelObject( / renderer().isSVGText() / ... accessors directly instead of is<RenderSVGModelObject>(renderer()).

For consistency reasons, I've decided to cleanup this while I'm at it -- that's the diff from patch v1 -> v2.
Comment 3 Nikolas Zimmermann 2022-02-06 03:00:18 PST 
Created attachment 451031 [details]
Patch, v2
Comment 4 Nikolas Zimmermann 2022-02-07 04:51:38 PST 
Committed r289207 (246892@trunk): <https://commits.webkit.org/246892@trunk>
Comment 5 Radar WebKit Bug Importer 2022-02-07 04:52:19 PST 
<rdar://problem/88566767>