Bug 236187

Summary: [LBSE] Apply position / size to SVG layers
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, pdr, rbuis, sabouhallawa, simon.fraser, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 90738, 236194    
Attachments:
Description Flags
Patch, v1
none
Patch, v2 rbuis: review+

Nikolas Zimmermann
Reported 2022-02-05 16:24:37 PST
Prepare RenderLayer/RenderLayerBacking for RenderSVGModelObject support: Teach RenderLayer::updateLayerPosition() about RenderSVGModelObject derived renderers that create layers. Grab size and position information from the SVG render tree, just as done for CSS boxes in the render tree.
Attachments
Patch, v1 (4.63 KB, patch)
2022-02-05 16:40 PST, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Patch, v2 (4.73 KB, patch)
2022-02-06 03:00 PST, Nikolas Zimmermann 		rbuis: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2022-02-05 16:40:19 PST
Created attachment 451012 [details] Patch, v1
Nikolas Zimmermann
Comment 2 2022-02-06 03:00:01 PST
Revisiting the whole patch series I noticed this is one of the few places still using the renderer().isRenderSVGModelObject( / renderer().isSVGText() / ... accessors directly instead of is<RenderSVGModelObject>(renderer()). For consistency reasons, I've decided to cleanup this while I'm at it -- that's the diff from patch v1 -> v2.
Nikolas Zimmermann
Comment 3 2022-02-06 03:00:18 PST
Created attachment 451031 [details] Patch, v2
Nikolas Zimmermann
Comment 4 2022-02-07 04:51:38 PST
Committed r289207 (246892@trunk): <https://commits.webkit.org/246892@trunk>
Radar WebKit Bug Importer
Comment 5 2022-02-07 04:52:19 PST
<rdar://problem/88566767>
Note You need to log in before you can comment on or make changes to this bug.