Bug 236180

Summary: [WTF] Make Bitmap constexpr friendly
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, darin, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch darin: review+

Description Yusuke Suzuki 2022-02-05 11:23:41 PST 
[WTF] Make Bitmap constexpr friendly
Comment 1 Yusuke Suzuki 2022-02-05 11:27:50 PST 
Created attachment 450992 [details]
Patch
Comment 2 Yusuke Suzuki 2022-02-05 11:31:04 PST 
Created attachment 450993 [details]
Patch
Comment 3 Saam Barati 2022-02-05 13:17:52 PST 
Comment on attachment 450993 [details]
Patch

Lots of red.
Comment 4 Darin Adler 2022-02-05 16:28:27 PST 
Comment on attachment 450993 [details]
Patch

Looks great. I will review after you fix TestWebKitAPI
Comment 5 Yusuke Suzuki 2022-02-06 00:56:13 PST 
Created attachment 451026 [details]
Patch
Comment 6 Darin Adler 2022-02-06 10:45:19 PST 
Comment on attachment 451026 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451026&action=review

> Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:547
> +    static constexpr Bitmap<256> doNotUnescapeWhenDecodingURI = makeCharacterBitmap(

I would have written auto in these places instead of repeating the type.
Comment 7 Yusuke Suzuki 2022-02-06 11:15:43 PST 
Comment on attachment 451026 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451026&action=review

>> Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp:547
>> +    static constexpr Bitmap<256> doNotUnescapeWhenDecodingURI = makeCharacterBitmap(
> 
> I would have written auto in these places instead of repeating the type.

Changed.
Comment 8 Yusuke Suzuki 2022-02-06 11:17:36 PST 
Committed r289172 (246868@trunk): <https://commits.webkit.org/246868@trunk>
Comment 9 Radar WebKit Bug Importer 2022-02-06 11:18:17 PST 
<rdar://problem/88546704>
Comment 10 Yusuke Suzuki 2022-02-06 11:25:45 PST 
Committed r289173 (246869@trunk): <https://commits.webkit.org/246869@trunk>