Bug 236169

Summary: Notification refactoring
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, esprehn+autocc, ews-watchlist, kangil.han, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
EWS v1
ews-feeder: commit-queue-
EWS v2
ews-feeder: commit-queue-
EWS v3
ews-feeder: commit-queue-
EWS v4
ews-feeder: commit-queue-
EWS v5
achristensen: review+, ews-feeder: commit-queue-
EWS v6
none
EWS v7 ews-feeder: commit-queue-

Description Brady Eidson 2022-02-04 18:32:50 PST 
Notification refactoring

All in support of upcoming showNotification() work.

Splitting some "no behavior change" bits from a mega patch out here, including:
- Make Notification objects reliant on ScriptExecutionContext, and not Documents
- Give them more direct access to a NotificationClient instead of having to go through a Page's NotificationController
- Give ServiceWorkerGlobalScope objects a SessionID for future use
Comment 1 Brady Eidson 2022-02-04 18:41:36 PST 
Created attachment 450961 [details]
EWS v1
Comment 2 Brady Eidson 2022-02-04 19:11:18 PST 
Created attachment 450964 [details]
EWS v2
Comment 3 Brady Eidson 2022-02-04 19:23:03 PST 
Created attachment 450965 [details]
EWS v3
Comment 4 Brady Eidson 2022-02-04 19:41:42 PST 
Created attachment 450966 [details]
EWS v4
Comment 5 Brady Eidson 2022-02-04 19:55:47 PST 
Created attachment 450967 [details]
EWS v5
Comment 6 Brady Eidson 2022-02-04 20:30:23 PST 
Created attachment 450969 [details]
EWS v6
Comment 7 Brady Eidson 2022-02-04 21:25:45 PST 
Created attachment 450972 [details]
EWS v7
Comment 8 EWS 2022-02-05 00:11:47 PST 
Committed r289153 (246849@main): <https://commits.webkit.org/246849@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450972 [details].
Comment 9 Radar WebKit Bug Importer 2022-02-05 00:12:19 PST 
<rdar://problem/88522349>