Bug 23615

Summary:

Try to make layout test timeout-release-on-close.html reliable

Product:

WebKit

Reporter:

Dmitry Titov <dimich>

Component:

Tools / Tests

Assignee:

Dmitry Titov <dimich>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed patch	ap: review+

Description Dmitry Titov 2009-01-29 00:53:43 PST

This test sometimes fails on buildbots. I could not reproduce the failure, but looking at other similar tests (Layout/fast/dom/gc-10.html) I think the following can improve it:

- Use threshold when comparing the number of objects to account for objects that can be allocated by the running script itself.
- Increase the number of allocated objects that should be released to make test less sensitive to other allocations.
- Add debug output in case test fails to investigate further.

Patch is coming.

Comment 1 Dmitry Titov 2009-01-29 01:07:51 PST

Created attachment 27140 [details]
Proposed patch

Comment 2 Alexey Proskuryakov 2009-01-29 01:21:20 PST

Comment on attachment 27140 [details]
Proposed patch

r=me

Comment 3 Darin Fisher (:fishd, Google) 2009-01-30 09:07:19 PST

http://trac.webkit.org/changeset/40405