Bug 236136

Summary: [Flatpak SDK] Update to FDO 21.08.10 and GStreamer 1.20 releases
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: Tools / TestsAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bugs-noreply, calvaris, cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, hta, jer.noble, menard, olivier.blin, philipj, sergio, tommyw, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=237872
Attachments:
Description Flags
[fast-cq] Patch none

Philippe Normand
Reported 2022-02-04 06:25:44 PST
.
Attachments
[fast-cq] Patch (62.39 KB, patch)
2022-02-04 09:44 PST, Philippe Normand 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2022-02-04 09:44:08 PST
Created attachment 450909 [details] [fast-cq] Patch
EWS
Comment 2 2022-02-05 01:26:21 PST
Committed r289154 (246850@main): <https://commits.webkit.org/246850@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450909 [details].
Radar WebKit Bug Importer
Comment 3 2022-02-05 01:27:17 PST
<rdar://problem/88523100>
Olivier Blin
Comment 4 2022-03-09 02:46:16 PST
Comment on attachment 450909 [details] [fast-cq] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450909&action=review > Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoDecoderFactory.cpp:370 > - if (factory && !g_strcmp0(GST_OBJECT_NAME(GST_OBJECT(factory.get())), "vp8dec")) { > - GST_INFO("Our best GStreamer VP8 decoder is vp8dec, better use the one from LibWebRTC"); > - > - return std::unique_ptr<webrtc::VideoDecoder>(new webrtc::LibvpxVp8Decoder()); > + if (!factory) { The check has been reversed, it should be "if (factory)" since the factory object is accessed in the code block.
Note You need to log in before you can comment on or make changes to this bug.