Bug 236112

Summary: Add pen type for HitTestRequest.
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Megan Gardner
Reported 2022-02-03 17:53:54 PST
Add pen type for HitTestRequest.
Attachments
Patch (2.22 KB, patch)
2022-02-03 17:54 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (2.22 KB, patch)
2022-02-03 17:57 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.22 KB, patch)
2022-02-03 18:33 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2022-02-03 17:54:46 PST
Created attachment 450842 [details] Patch
Tim Horton
Comment 2 2022-02-03 17:55:14 PST
Comment on attachment 450842 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450842&action=review > Source/WebCore/rendering/HitTestRequest.h:52 > + PenEvent = 1 << 15, Not sure why you're re-using a bit.
Tim Horton
Comment 3 2022-02-03 17:56:27 PST
Comment on attachment 450842 [details] Patch Also, not sure this should be landed separate from code that propagates it from the event, since as it stands this is untestable and zero-impact.
Megan Gardner
Comment 4 2022-02-03 17:57:17 PST
Created attachment 450843 [details] Patch
Megan Gardner
Comment 5 2022-02-03 18:33:16 PST
Created attachment 450849 [details] Patch for landing
EWS
Comment 6 2022-02-03 19:15:04 PST
Committed r289102 (246799@main): <https://commits.webkit.org/246799@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450849 [details].
Radar WebKit Bug Importer
Comment 7 2022-02-03 19:16:18 PST
<rdar://problem/88469338>
Note You need to log in before you can comment on or make changes to this bug.