Bug 236089

Summary: Rename ServiceWorkerInitializationData / ServiceWorkerInformation so they can be reused by shared workers
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, darin, ggaren, kkinnunen, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 235958    
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2022-02-03 09:47:57 PST
Rename ServiceWorkerInitializationData / ServiceWorkerInformation so they can be reused by shared workers.
Attachments
Patch (28.45 KB, patch)
2022-02-03 09:55 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2022-02-03 09:55:45 PST
Created attachment 450787 [details] Patch
Alex Christensen
Comment 2 2022-02-03 10:56:58 PST
Comment on attachment 450787 [details] Patch Is "RemoteWorker" used elsewhere? I might have called this ServiceOrSharedWorkerInformation
Chris Dumez
Comment 3 2022-02-03 11:02:08 PST
(In reply to Alex Christensen from comment #2) > Comment on attachment 450787 [details] > Patch > > Is "RemoteWorker" used elsewhere? > I might have called this ServiceOrSharedWorkerInformation Yes, I have used remote worker in a few patches already. The naming was suggested by Youenn during an earlier review.
Darin Adler
Comment 4 2022-02-03 11:34:31 PST
I am really happy to have a term of art instead of "x or y" every time!
EWS
Comment 5 2022-02-03 11:46:06 PST
Committed r289063 (246770@main): <https://commits.webkit.org/246770@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450787 [details].
Radar WebKit Bug Importer
Comment 6 2022-02-03 11:47:18 PST
<rdar://problem/88447663>
Note You need to log in before you can comment on or make changes to this bug.