| Summary: | [Web Animations] Starting a transform animation with a 1ms delay doesn't run it accelerated | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||||||
| Component: | Animations | Assignee: | Antoine Quint <graouts> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | changseok, dino, esprehn+autocc, ews-watchlist, fred.wang, glenn, graouts, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=229399 | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 450884 [details]
Patch
Comment on attachment 450884 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450884&action=review > Source/WebCore/ChangeLog:22 > + conditon to do so since its renderer is already composited. typo: condition Created attachment 450984 [details]
Patch
Created attachment 451071 [details]
Patch for landing
Committed r289211 (246896@main): <https://commits.webkit.org/246896@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451071 [details]. |
Created attachment 450769 [details] Testcase The attached example runs a simple "transform" animation with a 1ms delay and we fail to run the animation accelerated. Indeed, by the time we call startAnimation() the renderer is not composited and we bail, never to retry again. We must have some incorrect logic to indicate than the element has a pending accelerated animation and should be composited.