Bug 23603
| Summary: | REGRESSION: programmatic window sizing broken if window has multiple tabs | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alice Liu <alice.barraclough> |
| Component: | WebCore JavaScript | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | ap, darin, kevin, marhio, sullivan |
| Priority: | P2 | Keywords: | InRadar, Regression |
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | javascript:window.resizeTo(800,600); | ||
Alice Liu
programmatic window sizing is broken if window has multiple tabs Happens on both Mac and Windows. I'm running r40306.
Steps to repro:
1) open a new window, and if necessary, resize it to something you know of to be larger than 800x600
2) create a new tab in this window
3) javascript:window.resizeTo(800,600);
Results: resize doesn't work
4) close a tab
5) javascript:window.resizeTo(800,600);
Results: resize works
<rdar://problem/6537031>
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Cameron Zwarich (cpst)
moveTo also doesn't work.
Cameron Zwarich (cpst)
*** Bug 25289 has been marked as a duplicate of this bug. ***
Cameron Zwarich (cpst)
This appears to be a regression in Safari. When using Safari 3.2 with Safari 4.0 beta's WebKit or a a local debug build of WebKit it works fine.
Cameron Zwarich (cpst)
I'll mark this Invalid because it's a Safari bug. An Apple person should note this in the Radar.
Alexey Proskuryakov
*** Bug 24218 has been marked as a duplicate of this bug. ***
Alexey Proskuryakov
This was a deliberate behavior change to address the following highly annoying problem:
---------------------------
Steps to reproduce:
1. Go to http://www.cnn.com/POLITICS/
2. Middle/command click one of the video links
Results: The whole window is resized. I would expect the new tab to not affect the size of the window.
---------------------------
Judging from the number of complaints here and in duplicates, it is possible that the cure was worse than original problem. I can see how this is a problem for Web designers.
Kevin M. Dean
I'd be fine if the code was allowed to function when manually triggered from bookmarks even with multiple tabs while limiting the function when trigger from browser code in non-single window situations. Seems that would be a good compromise if that kind of delineation could be made.
Alexey Proskuryakov
Sounds reasonable to me, although I'm not immediately sure how to implement that. Another possible approach is to allow resizing from user gesture events.
Could you please file a new bug via <http://bugreport.apple.com>?
Kevin M. Dean
I believe the bug has already been filed a few times by people, so maybe someone more connected to Safari development can take a look a do what's best.
Alexey Proskuryakov
I took a look, which is why I asked to file a new bug.
Kevin M. Dean
There's a new Safari 5 extension that can resize the windows even with multiple tabs. It's quite nice.
http://www.apfelquak.de/2010/06/12/maximize-safari-extension/