| Summary: | Move and rename ServiceWorkerFrameLoaderClient & ServiceWorkerLibWebRTCProvider | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
| Component: | Service Workers | Assignee: | Chris Dumez <cdumez> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | achristensen, darin, ews-watchlist, ggaren, japhet, webkit-bug-importer, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 235958 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Chris Dumez
2022-02-02 07:44:14 PST
Created attachment 450644 [details]
Patch
Comment on attachment 450644 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450644&action=review > Source/WebCore/loader/FrameLoaderClient.h:354 > + virtual bool isWebWorkerFrameLoaderClient() const { return false; } Not sure WebWorker is a great name given DedicatedWorker would seem to fit there. Not sure I have a better name though, maybe RemoteWorker. (In reply to youenn fablet from comment #2) > Comment on attachment 450644 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=450644&action=review > > > Source/WebCore/loader/FrameLoaderClient.h:354 > > + virtual bool isWebWorkerFrameLoaderClient() const { return false; } > > Not sure WebWorker is a great name given DedicatedWorker would seem to fit > there. > Not sure I have a better name though, maybe RemoteWorker. My point of view was that: 1. Web is the usual prefix at the WebKit layer 2. This class could be used in theory with any type of worker (yes even dedicated ones) although there isn't any point in using it for dedicated workers since they are fully at the WebCore layer at the moment. That said, the RemoteWorker naming is growing on me :) Created attachment 450647 [details]
Patch
(In reply to Chris Dumez from comment #4) > That said, the RemoteWorker naming is growing on me :) Adopted before landing. Created attachment 450658 [details]
Patch
Comment on attachment 450658 [details] Patch Clearing flags on attachment: 450658 Committed r288972 (246701@trunk): <https://commits.webkit.org/246701@trunk> All reviewed patches have been landed. Closing bug. |