Bug 236016

Summary:

Move and rename ServiceWorkerFrameLoaderClient & ServiceWorkerLibWebRTCProvider

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Service Workers

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, darin, ews-watchlist, ggaren, japhet, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

235958

Attachments:

Description	Flags
Patch	none
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-

Chris Dumez

Reported 2022-02-02 07:44:14 PST

Move and rename ServiceWorkerFrameLoaderClient & ServiceWorkerLibWebRTCProvider so that they can be reused by Shared Workers.

Attachments
Patch (27.04 KB, patch) 2022-02-02 07:56 PST, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (27.23 KB, patch) 2022-02-02 08:45 PST, Chris Dumez	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (27.32 KB, patch) 2022-02-02 09:17 PST, Chris Dumez	ews-feeder: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2022-02-02 07:56:27 PST

Created attachment 450644 [details] Patch

youenn fablet

Comment 2 2022-02-02 08:19:25 PST

Comment on attachment 450644 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450644&action=review > Source/WebCore/loader/FrameLoaderClient.h:354 > + virtual bool isWebWorkerFrameLoaderClient() const { return false; } Not sure WebWorker is a great name given DedicatedWorker would seem to fit there. Not sure I have a better name though, maybe RemoteWorker.

Chris Dumez

Comment 3 2022-02-02 08:21:14 PST

(In reply to youenn fablet from comment #2) > Comment on attachment 450644 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=450644&action=review > > > Source/WebCore/loader/FrameLoaderClient.h:354 > > + virtual bool isWebWorkerFrameLoaderClient() const { return false; } > > Not sure WebWorker is a great name given DedicatedWorker would seem to fit > there. > Not sure I have a better name though, maybe RemoteWorker. My point of view was that: 1. Web is the usual prefix at the WebKit layer 2. This class could be used in theory with any type of worker (yes even dedicated ones) although there isn't any point in using it for dedicated workers since they are fully at the WebCore layer at the moment.

Chris Dumez

Comment 4 2022-02-02 08:23:36 PST

That said, the RemoteWorker naming is growing on me :)

Chris Dumez

Comment 5 2022-02-02 08:45:08 PST

Created attachment 450647 [details] Patch

Chris Dumez

Comment 6 2022-02-02 08:45:40 PST

(In reply to Chris Dumez from comment #4) > That said, the RemoteWorker naming is growing on me :) Adopted before landing.

Chris Dumez

Comment 7 2022-02-02 09:17:03 PST

Created attachment 450658 [details] Patch