Bug 236008

Summary:

Enable overflow:clip feature

Product:

WebKit

Reporter:

Rob Buis <rbuis>

Component:

CSS

Assignee:

Rob Buis <rbuis>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

crzwdjk, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

198230

Attachments:

Description	Flags
Patch	none

Rob Buis

Reported 2022-02-02 01:27:45 PST

Enable overflow:clip feature.

Attachments
Patch (1.38 KB, patch) 2022-02-02 01:29 PST, Rob Buis	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Rob Buis

Comment 1 2022-02-02 01:29:00 PST

Created attachment 450626 [details] Patch

Radar WebKit Bug Importer

Comment 2 2022-02-02 10:05:12 PST

<rdar://problem/88387256>

Arcady Goldmints-Orlov

Comment 3 2022-02-02 10:22:35 PST

Would it make sense to also unskip the tests still marked as skips and tagged with bug 198230? I.e. webkit.org/b/198230 imported/w3c/web-platform-tests/css/css-overflow/clip-003.html [ Skip ] webkit.org/b/198230 imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-intersection-observer.html [ Skip ] webkit.org/b/198230 imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-invalidation.html [ Skip ] webkit.org/b/198230 imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-001.html [ Skip ] webkit.org/b/198230 imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-002.html [ Skip ] webkit.org/b/198230 imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-003.html [ Skip ] webkit.org/b/198230 imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-004.html [ Skip ] webkit.org/b/198230 imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-005.html [ Skip ] webkit.org/b/198230 imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-006.html [ Skip ] webkit.org/b/198230 imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-007.html [ Skip ]

EWS

Comment 4 2022-02-02 11:31:18 PST

Committed r288973 (246702@main): <https://commits.webkit.org/246702@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450626 [details].

Rob Buis

Comment 5 2022-02-02 14:07:24 PST

(In reply to Arcady Goldmints-Orlov from comment #3) > Would it make sense to also unskip the tests still marked as skips and > tagged with bug 198230? I.e. > > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/clip-003.html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin- > intersection-observer.html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin- > invalidation.html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-001. > html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-002. > html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-003. > html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-004. > html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-005. > html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-006. > html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-007. > html [ Skip ] I think that is independent of this bug. i.e. they should pass (or not) independent of setting on by default (or not), as the tests should be run with experimental flags enabled.

Rob Buis

Comment 6 2022-02-03 04:31:39 PST

(In reply to Arcady Goldmints-Orlov from comment #3) > Would it make sense to also unskip the tests still marked as skips and > tagged with bug 198230? I.e. > > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/clip-003.html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin- > intersection-observer.html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin- > invalidation.html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-001. > html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-002. > html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-003. > html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-004. > html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-005. > html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-006. > html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-007. > html [ Skip ] Now that I look closer, we do not support the overflow-clip-margin property so most of these should not pass. If clip-003.html passes then I am in favour of not skipping it. In general I think we may not be aggressive enough regarding enabling tests, many times I see "unexpected pass" locally.

Simon Fraser (smfr)

Comment 7 2022-02-03 09:07:55 PST

Do we have a bug to implement overflow-clip-margin?

Rob Buis

Comment 8 2022-02-04 12:46:52 PST

(In reply to Simon Fraser (smfr) from comment #7) > Do we have a bug to implement overflow-clip-margin? I could not find anything relevant, so I created https://bugs.webkit.org/show_bug.cgi?id=236153.

Note You need to log in before you can comment on or make changes to this bug.