Bug 236002

Summary:

Rename FontCascade::spaceWidth() to FontCascade::spaceWidthOfPrimaryFont()

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Myles C. Maxfield 2022-02-01 22:02:17 PST

Rename FontCascade::spaceWidth() to FontCascade::spaceWidthOfPrimaryFont()

Comment 1 Myles C. Maxfield 2022-02-01 22:04:20 PST

Created attachment 450609 [details]
Patch

Comment 2 Myles C. Maxfield 2022-02-01 22:24:02 PST

Created attachment 450612 [details]
Patch

Comment 3 Myles C. Maxfield 2022-02-01 23:00:25 PST

Comment on attachment 450612 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450612&action=review

> Source/WebCore/platform/graphics/FontCascade.h:167
> +    float spaceWidthOfPrimaryFont() const { return primaryFont().spaceWidth() + m_letterSpacing; }

This probably isn't a great name, because it includes letter spacing.

Comment 4 Myles C. Maxfield 2022-02-01 23:55:21 PST


*** This bug has been marked as a duplicate of bug 236007 ***