Bug 236002

Summary: Rename FontCascade::spaceWidth() to FontCascade::spaceWidthOfPrimaryFont()
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Myles C. Maxfield
Reported 2022-02-01 22:02:17 PST
Rename FontCascade::spaceWidth() to FontCascade::spaceWidthOfPrimaryFont()
Attachments
Patch (7.63 KB, patch)
2022-02-01 22:04 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (5.03 KB, patch)
2022-02-01 22:24 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2022-02-01 22:04:20 PST
Created attachment 450609 [details] Patch
Myles C. Maxfield
Comment 2 2022-02-01 22:24:02 PST
Created attachment 450612 [details] Patch
Myles C. Maxfield
Comment 3 2022-02-01 23:00:25 PST
Comment on attachment 450612 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450612&action=review > Source/WebCore/platform/graphics/FontCascade.h:167 > + float spaceWidthOfPrimaryFont() const { return primaryFont().spaceWidth() + m_letterSpacing; } This probably isn't a great name, because it includes letter spacing.
Myles C. Maxfield
Comment 4 2022-02-01 23:55:21 PST
*** This bug has been marked as a duplicate of bug 236007 ***
Note You need to log in before you can comment on or make changes to this bug.