| Summary: | Adjust some Live Text code to only use VKC-prefixed VisionKit classes if ENABLE(IMAGE_ANALYSIS_ENHANCEMENTS) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||
| Component: | Platform | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | akeerthi, bdakin, hi, megan_gardner, thorton, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 235980 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Wenson Hsieh
2022-02-01 17:36:39 PST
Created attachment 450597 [details]
Patch
Comment on attachment 450597 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450597&action=review > Source/WebKit/Platform/cocoa/TextRecognitionUtilities.h:57 > +RetainPtr<CocoaImageAnalyzerRequest> createImageAnalyzerRequest(CGImageRef, VKAnalysisTypes); Is VKAnalysisTypes not also getting replaced? Thanks for the review! (In reply to Megan Gardner from comment #2) > Comment on attachment 450597 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=450597&action=review > > > Source/WebKit/Platform/cocoa/TextRecognitionUtilities.h:57 > > +RetainPtr<CocoaImageAnalyzerRequest> createImageAnalyzerRequest(CGImageRef, VKAnalysisTypes); > > Is VKAnalysisTypes not also getting replaced? Indeed — `VKAnalysisTypes` are remaining as-is. I'll check in with the relevant folks to see if this is intentional... Committed r288956 (246685@main): <https://commits.webkit.org/246685@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450597 [details]. |