Bug 235991

Summary: Adjust some Live Text code to only use VKC-prefixed VisionKit classes if ENABLE(IMAGE_ANALYSIS_ENHANCEMENTS)
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: PlatformAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, bdakin, hi, megan_gardner, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 235980    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Wenson Hsieh
Reported 2022-02-01 17:36:39 PST
.
Attachments
Patch (17.69 KB, patch)
2022-02-01 17:48 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2022-02-01 17:48:04 PST
Created attachment 450597 [details] Patch
Megan Gardner
Comment 2 2022-02-02 09:41:42 PST
Comment on attachment 450597 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450597&action=review > Source/WebKit/Platform/cocoa/TextRecognitionUtilities.h:57 > +RetainPtr<CocoaImageAnalyzerRequest> createImageAnalyzerRequest(CGImageRef, VKAnalysisTypes); Is VKAnalysisTypes not also getting replaced?
Wenson Hsieh
Comment 3 2022-02-02 09:45:02 PST
Thanks for the review! (In reply to Megan Gardner from comment #2) > Comment on attachment 450597 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=450597&action=review > > > Source/WebKit/Platform/cocoa/TextRecognitionUtilities.h:57 > > +RetainPtr<CocoaImageAnalyzerRequest> createImageAnalyzerRequest(CGImageRef, VKAnalysisTypes); > > Is VKAnalysisTypes not also getting replaced? Indeed — `VKAnalysisTypes` are remaining as-is. I'll check in with the relevant folks to see if this is intentional...
EWS
Comment 4 2022-02-02 09:53:49 PST
Committed r288956 (246685@main): <https://commits.webkit.org/246685@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450597 [details].
Radar WebKit Bug Importer
Comment 5 2022-02-02 09:54:33 PST
<rdar://problem/88386531>
Note You need to log in before you can comment on or make changes to this bug.