Bug 235972

Summary: Add setting to toggle PDF.js viewer
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: PDFAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 235969    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Tim Nguyen (:ntim)
Reported 2022-02-01 13:10:04 PST
^
Attachments
Patch (4.06 KB, patch)
2022-02-01 15:02 PST, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Patch (4.03 KB, patch)
2022-02-01 15:10 PST, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Patch (2.66 KB, patch)
2022-02-01 15:15 PST, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-02-01 13:10:16 PST
<rdar://problem/88344595>
Tim Nguyen (:ntim)
Comment 2 2022-02-01 15:02:24 PST
Created attachment 450574 [details] Patch
Tim Nguyen (:ntim)
Comment 3 2022-02-01 15:10:16 PST
Created attachment 450577 [details] Patch
Tim Horton
Comment 4 2022-02-01 15:12:02 PST
Comment on attachment 450577 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450577&action=review > Tools/WebKitTestRunner/TestOptions.cpp:111 > + { "PdfJSViewerEnabled", false }, I think you can get rid of this now that it's not experimental
Chris Dumez
Comment 5 2022-02-01 15:12:13 PST
Comment on attachment 450577 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450577&action=review > Tools/WebKitTestRunner/TestOptions.cpp:111 > + { "PdfJSViewerEnabled", false }, Should no longer be needed now that it is no longer experimental.
Tim Nguyen (:ntim)
Comment 6 2022-02-01 15:15:27 PST
Created attachment 450578 [details] Patch
EWS
Comment 7 2022-02-01 17:19:20 PST
Committed r288930 (246661@main): <https://commits.webkit.org/246661@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450578 [details].
Note You need to log in before you can comment on or make changes to this bug.