Bug 235972

Summary: Add setting to toggle PDF.js viewer
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: PDFAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 235969    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Tim Nguyen (:ntim) 2022-02-01 13:10:04 PST 
^
Comment 1 Radar WebKit Bug Importer 2022-02-01 13:10:16 PST 
<rdar://problem/88344595>
Comment 2 Tim Nguyen (:ntim) 2022-02-01 15:02:24 PST 
Created attachment 450574 [details]
Patch
Comment 3 Tim Nguyen (:ntim) 2022-02-01 15:10:16 PST 
Created attachment 450577 [details]
Patch
Comment 4 Tim Horton 2022-02-01 15:12:02 PST 
Comment on attachment 450577 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450577&action=review

> Tools/WebKitTestRunner/TestOptions.cpp:111
> +            { "PdfJSViewerEnabled", false },

I think you can get rid of this now that it's not experimental
Comment 5 Chris Dumez 2022-02-01 15:12:13 PST 
Comment on attachment 450577 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450577&action=review

> Tools/WebKitTestRunner/TestOptions.cpp:111
> +            { "PdfJSViewerEnabled", false },

Should no longer be needed now that it is no longer experimental.
Comment 6 Tim Nguyen (:ntim) 2022-02-01 15:15:27 PST 
Created attachment 450578 [details]
Patch
Comment 7 EWS 2022-02-01 17:19:20 PST 
Committed r288930 (246661@main): <https://commits.webkit.org/246661@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 450578 [details].