Bug 235959

Summary: [REGRESSION][WinCairo] Since r288284 compilation fails when REMOTE_INSPECTOR is enabled
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: CMakeAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, don.olmstead, ews-watchlist, fujii.hironori, gyuyoung.kim, ryuan.choi, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 194905    
Attachments:
Description Flags
Patch none

Yury Semikhatsky
Reported 2022-02-01 09:14:16 PST
WinCairo compilation fails after https://trac.webkit.org/changeset/288284/webkit if REMOTE_INSPECTOR is enabled. It looks like WebProcessPoolWin does depend on Core Foundation for loading inspector resources: 58>D:\webkit\Source\WebKit\UIProcess\win\WebProcessPoolWin.cpp(44,15): error C2065: 'CFURLRef': undeclared identifier 58>D:\webkit\Source\WebKit\UIProcess\win\WebProcessPoolWin.cpp(44,5): error C2923: 'WTF::RetainPtr': 'CFURLRef' is not a valid template type argument for parameter '<unnamed-symbol>' 58>D:\webkit\Source\WebKit\UIProcess\win\WebProcessPoolWin.cpp(44): message : see declaration of 'CFURLRef' 58>D:\webkit\Source\WebKit\UIProcess\win\WebProcessPoolWin.cpp(44,75): error C2039: 'webKitBundle': is not a member of 'WebCore' 58>D:\webkit\Source\WebKit\UIProcess\WebProcessPool.h(94): message : see declaration of 'WebCore'
Attachments
Patch (1.50 KB, patch)
2022-02-01 12:14 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2022-02-01 12:14:13 PST
Created attachment 450556 [details] Patch We should revert r288284 until WinCairo WK2 will remove the CF dependency (Bug 176236).
Fujii Hironori
Comment 2 2023-02-12 17:26:01 PST
Fixed by 260172@main.
Note You need to log in before you can comment on or make changes to this bug.