| Summary: | [Forms] Alias appearance <compat-auto> keywords to 'auto' | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zsun | ||||||||||
| Component: | Forms | Assignee: | zsun | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | akeerthi, cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, ntim, pdr, webkit-bug-importer, wenson_hsieh | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
zsun
2022-02-01 03:08:39 PST
Created attachment 450632 [details]
Patch
Created attachment 450687 [details]
Patch
Created attachment 450744 [details]
Patch
Comment on attachment 450744 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450744&action=review > Source/WebCore/rendering/RenderTheme.cpp:90 > + if (!element) Nit: The early return here can be moved before the declaration/assignment of `part`. > Source/WebCore/rendering/RenderTheme.h:469 > + ControlPart adjustAppearanceWithElementType(RenderStyle&, const Element*) const; Consider renaming this to `adjustAppearanceForElement`, since it doesn't take an "element type". Created attachment 450880 [details]
Patch
Committed r289201 (246887@main): <https://commits.webkit.org/246887@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450880 [details]. |