Bug 235944

Summary: [Forms] Alias appearance <compat-auto> keywords to 'auto'
Product: WebKit Reporter: zsun
Component: FormsAssignee: zsun
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, ntim, pdr, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Attachments
Patch (14.12 KB, patch)
2022-02-02 04:11 PST, zsun 		no flags
DetailsFormatted DiffDiff
Patch (10.62 KB, patch)
2022-02-02 12:06 PST, zsun 		no flags
DetailsFormatted DiffDiff
Patch (10.28 KB, patch)
2022-02-03 01:11 PST, zsun 		no flags
DetailsFormatted DiffDiff
Patch (10.26 KB, patch)
2022-02-04 01:19 PST, zsun 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
zsun
Comment 1 2022-02-02 04:11:09 PST
Created attachment 450632 [details] Patch
zsun
Comment 2 2022-02-02 12:06:47 PST
Created attachment 450687 [details] Patch
zsun
Comment 3 2022-02-03 01:11:47 PST
Created attachment 450744 [details] Patch
Aditya Keerthi
Comment 4 2022-02-03 14:15:42 PST
Comment on attachment 450744 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450744&action=review > Source/WebCore/rendering/RenderTheme.cpp:90 > + if (!element) Nit: The early return here can be moved before the declaration/assignment of `part`. > Source/WebCore/rendering/RenderTheme.h:469 > + ControlPart adjustAppearanceWithElementType(RenderStyle&, const Element*) const; Consider renaming this to `adjustAppearanceForElement`, since it doesn't take an "element type".
zsun
Comment 5 2022-02-04 01:19:40 PST
Created attachment 450880 [details] Patch
EWS
Comment 6 2022-02-07 01:23:41 PST
Committed r289201 (246887@main): <https://commits.webkit.org/246887@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450880 [details].
Radar WebKit Bug Importer
Comment 7 2022-02-07 01:24:19 PST
<rdar://problem/88561704>
Note You need to log in before you can comment on or make changes to this bug.