Bug 235943
| Summary: | Check that LayoutTests/resources/testharness.js is in sync with LayoutTests/imported/w3c/web-platform-tests/resources/testharness.js | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ap, gsnedders, mbrodesser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=235398 | ||
Kimmo Kinnunen
Check that LayoutTests/resources/testharness.js is in sync with LayoutTests/imported/w3c/web-platform-tests/resources/testharness.js
Do this also for dependencies.
It makes sense to keep testharness.js matching the big chunk of imported test cases that use the harness.
It makes sense to keep testharness.js relatively up to date:
- to get improvements in testharness.js (maybe more strict assertions, tests more)
- to match what web-platform-tests need in case the tests are upstreamed
- to match what online documentation says about testharness.js
testharness.js dependencies are as of writing:
- idlharness.js
- webidl2.js copied to WebIDLParser.js
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/88619980>
Sam Sneddon [:gsnedders]
An extreme option here would be to simply use symlinks here, given I think that nowadays works everywhere (including/notably Windows), but that would be rather notable as we don't have any symlinks currently.
Mirko Brodesser
For the record, at least <LayoutTests/imported/w3c/web-platform-tests/resources/testharness.js> is outdated. Roughly two years since the last sync. See https://github.com/WebKit/WebKit/pull/40755/files/17e8f7f6fb68da4a916dd198a0be8bbb60d0c860#r1969537981.