Bug 235940

Summary: Revert OSAllocator behavior to pre-Structure-Allocator change one
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+, ews-feeder: commit-queue-

Yusuke Suzuki
Reported 2022-01-31 23:43:02 PST
Revert OSAllocator behavior to pre-Structure-Allocator change one
Attachments
Patch (14.34 KB, patch)
2022-01-31 23:53 PST, Yusuke Suzuki 		mark.lam: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2022-01-31 23:53:20 PST
Created attachment 450504 [details] Patch
Mark Lam
Comment 2 2022-02-01 00:53:15 PST
Comment on attachment 450504 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450504&action=review r=me > Source/WTF/ChangeLog:42 > + We also fix that tryReserveUncommitted is not correctly handling MAP_FAILED. We should not return MAP_FAILED from OSAllocator, instead, I suggest "fix that tryReserveUncommitted is not correctly handling MAP_FAILED" => "fix a bug in tryReserveUncommitted where it handles MAP_FAILED incorrectly". > Source/WTF/wtf/posix/OSAllocatorPOSIX.cpp:116 > +void* OSAllocator::tryReserveUncommitted(size_t bytes, Usage usage, bool writable, bool executable, bool jitCageEnabled, bool includesGuardPages) Why remove the "OSAllocator::" qualifier for Usage? You kept to for tryReserveAndCommit above. I see that it is not used for functions below. Maybe remove it also for tryReserveAndCommit above?
Yusuke Suzuki
Comment 3 2022-02-01 01:15:44 PST
Comment on attachment 450504 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450504&action=review >> Source/WTF/ChangeLog:42 >> + We also fix that tryReserveUncommitted is not correctly handling MAP_FAILED. We should not return MAP_FAILED from OSAllocator, instead, > > I suggest "fix that tryReserveUncommitted is not correctly handling MAP_FAILED" => "fix a bug in tryReserveUncommitted where it handles MAP_FAILED incorrectly". Changed. >> Source/WTF/wtf/posix/OSAllocatorPOSIX.cpp:116 >> +void* OSAllocator::tryReserveUncommitted(size_t bytes, Usage usage, bool writable, bool executable, bool jitCageEnabled, bool includesGuardPages) > > Why remove the "OSAllocator::" qualifier for Usage? You kept to for tryReserveAndCommit above. I see that it is not used for functions below. Maybe remove it also for tryReserveAndCommit above? Because now it is static function of OSAllocator::. So, we don't need OSAllocator:: prefix to Usage. Removed that of tryReserveAndCommit too.
Yusuke Suzuki
Comment 4 2022-02-01 02:26:42 PST
Committed r288870 (246622@trunk): <https://commits.webkit.org/246622@trunk>
Radar WebKit Bug Importer
Comment 5 2022-02-01 02:27:18 PST
<rdar://problem/88318960>
Note You need to log in before you can comment on or make changes to this bug.