Bug 23593

Summary: RenderThemeChromium[Win,Mac].cpp don't compile after renderbox changes
Product: WebKit Reporter: Tony Chang <tony>
Component: WebCore Misc.Assignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
[1/1] Compile fixes for RenderThemeChromiumMac and RenderThemeChromiumWin.
hyatt: review+
[1/1] Compile fixes for RenderThemeChromiumMac and RenderThemeChromiumWin. none

Tony Chang
Reported 2009-01-28 11:29:00 PST
Patch coming...
Attachments
[1/1] Compile fixes for RenderThemeChromiumMac and RenderThemeChromiumWin. (3.82 KB, patch)
2009-01-28 11:38 PST, Tony Chang 		hyatt: review+
DetailsFormatted DiffDiff
[1/1] Compile fixes for RenderThemeChromiumMac and RenderThemeChromiumWin. (3.91 KB, patch)
2009-01-28 11:51 PST, Tony Chang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2009-01-28 11:38:43 PST
Created attachment 27113 [details] [1/1] Compile fixes for RenderThemeChromiumMac and RenderThemeChromiumWin. This is a follow up for hyatt's RenderBox changes. --- WebCore/ChangeLog | 12 ++++++++++++ WebCore/rendering/RenderThemeChromiumMac.mm | 6 ++++-- WebCore/rendering/RenderThemeChromiumWin.cpp | 18 ++++++++++-------- 3 files changed, 26 insertions(+), 10 deletions(-)
Dave Hyatt
Comment 2 2009-01-28 11:43:07 PST
Comment on attachment 27113 [details] [1/1] Compile fixes for RenderThemeChromiumMac and RenderThemeChromiumWin. You should add isBox() checks and bail with early returns so you don't do a bad cast by accident. Fix that and r=me.
Tony Chang
Comment 3 2009-01-28 11:51:41 PST
Created attachment 27114 [details] [1/1] Compile fixes for RenderThemeChromiumMac and RenderThemeChromiumWin. This is a follow up for hyatt's RenderBox changes. --- WebCore/ChangeLog | 12 ++++++++++++ WebCore/rendering/RenderThemeChromiumMac.mm | 9 +++++++-- WebCore/rendering/RenderThemeChromiumWin.cpp | 21 +++++++++++++-------- 3 files changed, 32 insertions(+), 10 deletions(-)
Darin Fisher (:fishd, Google)
Comment 4 2009-01-28 12:37:54 PST
http://trac.webkit.org/changeset/40321
Note You need to log in before you can comment on or make changes to this bug.