| Summary: | RenderThemeChromium[Win,Mac].cpp don't compile after renderbox changes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tony Chang <tony> | ||||||
| Component: | WebCore Misc. | Assignee: | Tony Chang <tony> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | ||||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Mac | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Tony Chang
2009-01-28 11:29:00 PST
Created attachment 27113 [details]
[1/1] Compile fixes for RenderThemeChromiumMac and RenderThemeChromiumWin.
This is a follow up for hyatt's RenderBox changes.
---
WebCore/ChangeLog | 12 ++++++++++++
WebCore/rendering/RenderThemeChromiumMac.mm | 6 ++++--
WebCore/rendering/RenderThemeChromiumWin.cpp | 18 ++++++++++--------
3 files changed, 26 insertions(+), 10 deletions(-)
Comment on attachment 27113 [details]
[1/1] Compile fixes for RenderThemeChromiumMac and RenderThemeChromiumWin.
You should add isBox() checks and bail with early returns so you don't do a bad cast by accident. Fix that and r=me.
Created attachment 27114 [details]
[1/1] Compile fixes for RenderThemeChromiumMac and RenderThemeChromiumWin.
This is a follow up for hyatt's RenderBox changes.
---
WebCore/ChangeLog | 12 ++++++++++++
WebCore/rendering/RenderThemeChromiumMac.mm | 9 +++++++--
WebCore/rendering/RenderThemeChromiumWin.cpp | 21 +++++++++++++--------
3 files changed, 32 insertions(+), 10 deletions(-)
|