Bug 235929

Summary: [iOS] Clean up some issues in the 'com.apple.WebKit.adattributiond.sb' sandbox
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Brent Fulgham
Reported 2022-01-31 16:58:34 PST
This patch cleans up some issues hit when compiling this new sandbox.
Attachments
Patch (3.55 KB, patch)
2022-01-31 17:01 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (3.41 KB, patch)
2022-01-31 17:18 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.54 KB, patch)
2022-01-31 17:20 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2022-01-31 17:01:11 PST
Created attachment 450477 [details] Patch
Alex Christensen
Comment 2 2022-01-31 17:11:34 PST
Comment on attachment 450477 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450477&action=review > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.adattributiond.sb:74 > + (home-subpath "/var/mobile/Library/com.apple.webkit.addattributiond/Version1")) Let's make this /var/mobile/Library/com.apple.webkit.addattributiond instead of /var/mobile/Library/com.apple.webkit.addattributiond/Version1
Alex Christensen
Comment 3 2022-01-31 17:18:34 PST
Comment on attachment 450477 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450477&action=review >> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.adattributiond.sb:74 >> + (home-subpath "/var/mobile/Library/com.apple.webkit.addattributiond/Version1")) > > Let's make this /var/mobile/Library/com.apple.webkit.addattributiond instead of /var/mobile/Library/com.apple.webkit.addattributiond/Version1 I also think we need subpath instead of home-subpath
Alex Christensen
Comment 4 2022-01-31 17:18:56 PST
Created attachment 450479 [details] Patch
Alex Christensen
Comment 5 2022-01-31 17:19:32 PST
r288860
Brent Fulgham
Comment 6 2022-01-31 17:20:22 PST
Reopening to attach new patch.
Brent Fulgham
Comment 7 2022-01-31 17:20:24 PST
Created attachment 450480 [details] Patch for landing
Brent Fulgham
Comment 8 2022-01-31 17:21:09 PST
I didn't notice Alex already landed this in r288860.
Brent Fulgham
Comment 9 2022-01-31 17:21:36 PST
<rdar://88081007>
Note You need to log in before you can comment on or make changes to this bug.