Bug 235919

Summary: Use more AtomString and un-inline code for ScriptElementCachedScriptFetcher and its subclasses
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, esprehn+autocc, ews-watchlist, kangil.han, koivisto, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=235876
Attachments:
Description Flags
Patch
none
Patch none

Description Ryosuke Niwa 2022-01-31 13:55:24 PST 
Cleanup suggested by Darin in https://bugs.webkit.org/show_bug.cgi?id=235876.
Comment 1 Ryosuke Niwa 2022-01-31 14:26:51 PST 
Created attachment 450463 [details]
Patch
Comment 2 Ryosuke Niwa 2022-01-31 14:29:05 PST 
Created attachment 450464 [details]
Patch
Comment 3 Darin Adler 2022-02-01 08:52:45 PST 
Comment on attachment 450464 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450464&action=review

> Source/WebCore/dom/LoadableClassicScript.cpp:44
> +LoadableClassicScript::LoadableClassicScript(const String& nonce, const AtomString& integrity, ReferrerPolicy policy, const AtomString& crossOriginMode, const String& charset, const AtomString& initiatorName, bool isInUserAgentShadowTree, bool isAsync)

Was nonce going to be AtomString?
Comment 4 Ryosuke Niwa 2022-02-01 11:10:34 PST 
(In reply to Darin Adler from comment #3)
> Comment on attachment 450464 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450464&action=review
> 
> > Source/WebCore/dom/LoadableClassicScript.cpp:44
> > +LoadableClassicScript::LoadableClassicScript(const String& nonce, const AtomString& integrity, ReferrerPolicy policy, const AtomString& crossOriginMode, const String& charset, const AtomString& initiatorName, bool isInUserAgentShadowTree, bool isAsync)
> 
> Was nonce going to be AtomString?

Yup. In Element.h we see that:

...
    WEBCORE_EXPORT const AtomString& nonce() const;
...
Comment 5 Ryosuke Niwa 2022-02-01 11:12:56 PST 
Comment on attachment 450464 [details]
Patch

Clearing flags on attachment: 450464

Committed r288900 (?): <https://commits.webkit.org/r288900>
Comment 6 Ryosuke Niwa 2022-02-01 11:12:59 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2022-02-01 11:13:39 PST 
<rdar://problem/88338714>
Comment 8 Darin Adler 2022-02-01 12:24:58 PST 
Comment on attachment 450464 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450464&action=review

>>> Source/WebCore/dom/LoadableClassicScript.cpp:44
>>> +LoadableClassicScript::LoadableClassicScript(const String& nonce, const AtomString& integrity, ReferrerPolicy policy, const AtomString& crossOriginMode, const String& charset, const AtomString& initiatorName, bool isInUserAgentShadowTree, bool isAsync)
>> 
>> Was nonce going to be AtomString?
> 
> Yup. In Element.h we see that:
> 
> ...
>     WEBCORE_EXPORT const AtomString& nonce() const;
> ...

My point is that the code above says const String& nonce instead of const AtomString& nonce.
Comment 9 Ryosuke Niwa 2022-02-01 14:09:08 PST 
(In reply to Darin Adler from comment #8)
> Comment on attachment 450464 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450464&action=review
> 
> >>> Source/WebCore/dom/LoadableClassicScript.cpp:44
> >>> +LoadableClassicScript::LoadableClassicScript(const String& nonce, const AtomString& integrity, ReferrerPolicy policy, const AtomString& crossOriginMode, const String& charset, const AtomString& initiatorName, bool isInUserAgentShadowTree, bool isAsync)
> >> 
> >> Was nonce going to be AtomString?
> > 
> > Yup. In Element.h we see that:
> > 
> > ...
> >     WEBCORE_EXPORT const AtomString& nonce() const;
> > ...
> 
> My point is that the code above says const String& nonce instead of const
> AtomString& nonce.

Oh! I missed that. Will fix.
Comment 10 Ryosuke Niwa 2022-02-01 14:13:09 PST 
Committed r288912 (246652@trunk): <https://commits.webkit.org/246652@trunk>