Bug 235919

Summary:

Use more AtomString and un-inline code for ScriptElementCachedScriptFetcher and its subclasses

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

DOM

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, darin, esprehn+autocc, ews-watchlist, kangil.han, koivisto, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=235876

Attachments:

Description	Flags
Patch	none
Patch	none

Ryosuke Niwa

Reported 2022-01-31 13:55:24 PST

Cleanup suggested by Darin in https://bugs.webkit.org/show_bug.cgi?id=235876.

Attachments
Patch (14.88 KB, patch) 2022-01-31 14:26 PST, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Patch (14.99 KB, patch) 2022-01-31 14:29 PST, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2022-01-31 14:26:51 PST

Created attachment 450463 [details] Patch

Ryosuke Niwa

Comment 2 2022-01-31 14:29:05 PST

Created attachment 450464 [details] Patch

Darin Adler

Comment 3 2022-02-01 08:52:45 PST

Comment on attachment 450464 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450464&action=review > Source/WebCore/dom/LoadableClassicScript.cpp:44 > +LoadableClassicScript::LoadableClassicScript(const String& nonce, const AtomString& integrity, ReferrerPolicy policy, const AtomString& crossOriginMode, const String& charset, const AtomString& initiatorName, bool isInUserAgentShadowTree, bool isAsync) Was nonce going to be AtomString?

Ryosuke Niwa

Comment 4 2022-02-01 11:10:34 PST

(In reply to Darin Adler from comment #3) > Comment on attachment 450464 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=450464&action=review > > > Source/WebCore/dom/LoadableClassicScript.cpp:44 > > +LoadableClassicScript::LoadableClassicScript(const String& nonce, const AtomString& integrity, ReferrerPolicy policy, const AtomString& crossOriginMode, const String& charset, const AtomString& initiatorName, bool isInUserAgentShadowTree, bool isAsync) > > Was nonce going to be AtomString? Yup. In Element.h we see that: ... WEBCORE_EXPORT const AtomString& nonce() const; ...

Ryosuke Niwa

Comment 5 2022-02-01 11:12:56 PST

Comment on attachment 450464 [details] Patch Clearing flags on attachment: 450464 Committed r288900 (?): <https://commits.webkit.org/r288900>

Ryosuke Niwa

Comment 6 2022-02-01 11:12:59 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 7 2022-02-01 11:13:39 PST

<rdar://problem/88338714>

Darin Adler

Comment 8 2022-02-01 12:24:58 PST

Comment on attachment 450464 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450464&action=review >>> Source/WebCore/dom/LoadableClassicScript.cpp:44 >>> +LoadableClassicScript::LoadableClassicScript(const String& nonce, const AtomString& integrity, ReferrerPolicy policy, const AtomString& crossOriginMode, const String& charset, const AtomString& initiatorName, bool isInUserAgentShadowTree, bool isAsync) >> >> Was nonce going to be AtomString? > > Yup. In Element.h we see that: > > ... > WEBCORE_EXPORT const AtomString& nonce() const; > ... My point is that the code above says const String& nonce instead of const AtomString& nonce.

Ryosuke Niwa

Comment 9 2022-02-01 14:09:08 PST

(In reply to Darin Adler from comment #8) > Comment on attachment 450464 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=450464&action=review > > >>> Source/WebCore/dom/LoadableClassicScript.cpp:44 > >>> +LoadableClassicScript::LoadableClassicScript(const String& nonce, const AtomString& integrity, ReferrerPolicy policy, const AtomString& crossOriginMode, const String& charset, const AtomString& initiatorName, bool isInUserAgentShadowTree, bool isAsync) > >> > >> Was nonce going to be AtomString? > > > > Yup. In Element.h we see that: > > > > ... > > WEBCORE_EXPORT const AtomString& nonce() const; > > ... > > My point is that the code above says const String& nonce instead of const > AtomString& nonce. Oh! I missed that. Will fix.

Ryosuke Niwa

Comment 10 2022-02-01 14:13:09 PST

Committed r288912 (246652@trunk): <https://commits.webkit.org/246652@trunk>

Note You need to log in before you can comment on or make changes to this bug.